Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 | Make the Wait Timeout for the Card Removal Trigger a Configurable Property #2090

Open
PartTimeIndie opened this issue Nov 2, 2023 · 0 comments
Labels
enhancement future3 Relates to future3 development help wanted

Comments

@PartTimeIndie
Copy link

Feature Description

Make the Wait Timeout for the Card Removal Trigger a Configurable Property

What functionality would you like to see in your phoniebox?

I need this Property because I had some issues with some cheaper Stickers loosing connection

How do you envision the feature to work from a users perspective?

Make it a Configuration similar to the Second Swipe Delay

Further information that might help

As a workaround I just change it in jukebox/components/rfid/reader/init.py

def run(self):
      self._logger.debug("CardRemovalTimerClass watchdog started")
      has_timed_out = True
      while True:
          # Prevent max CPU by forced loop slow down when self.trigger.is_set() is permanently high
          time.sleep(0.2)
          # This is the actual timer:
          # self.trigger.wait() aborts immediately when trigger.is_set becomes True
          **self.trigger.wait(2) <- Here I change the value**
          if self.trigger.is_set():

I never did anything with python before so I am to lazy to do a pull request and learn it enough to get it working. When I tried a ran into multiple problems. I still think other users will benifit from such a property.

@s-martin s-martin added the future3 Relates to future3 development label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement future3 Relates to future3 development help wanted
Projects
None yet
Development

No branches or pull requests

2 participants