Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future3 | zmq not installed in Github action pytest environment #2219

Open
votti opened this issue Jan 19, 2024 · 1 comment
Open

Future3 | zmq not installed in Github action pytest environment #2219

votti opened this issue Jan 19, 2024 · 1 comment
Labels
bug future3 Relates to future3 development investigation needed

Comments

@votti
Copy link

votti commented Jan 19, 2024

Bug

What I did

I wrote a unittest for a new feature

What happened

Inoticed that the github action workflow was failing due to a missing zmq installation as zmq is currently not installed as part of the testing workflow: https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/future3/develop/.github/workflows/pythonpackage_future3.yml

I expected this to happen

zmq should be also present in the github action workflow python environment used to run tests.

Further information that might help

A link to a failing job.
https://github.com/MiczFlor/RPi-Jukebox-RFID/actions/runs/7585060379/job/20660073103

A workaround that worked for me was to use unitest.mock to avoid importing zmq for my tests:
a181f8c

@s-martin
Copy link
Collaborator

I tend to the conclusion that it's ok to mock zmq for unit tests (as long as zmq is not directly used in the tests).

@s-martin s-martin added investigation needed future3 Relates to future3 development and removed needs triage labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug future3 Relates to future3 development investigation needed
Projects
None yet
Development

No branches or pull requests

2 participants