Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to TypeScript #1459

Open
pro-vi opened this issue May 20, 2024 · 3 comments
Open

Migration to TypeScript #1459

pro-vi opened this issue May 20, 2024 · 3 comments

Comments

@pro-vi
Copy link

pro-vi commented May 20, 2024

This project is going to scale and it should adopt TypeScript as early as possible. TS has a much better DX compared to plain JS without JSDoc and that alone should attract more open source efforts in the long run. If there's no obvious reasons that I missed, I'd love to help out along the way since I want to see success in the project.

@jazelly
Copy link
Contributor

jazelly commented May 20, 2024

+1 on this

@atljoseph
Copy link

+1 had asked about this in the discord but got lost in the chatter. Yessss! Thank you

@timothycarambat
Copy link
Member

While I don't disagree that TS has a better DX, the amount of effort this would take is pretty substantial and should be done in stages. I would ask that nobody take it upon themselves and we would execute this in stages as the core team. There are a number of side effects to doing this in the repo that could impact projects running AnythingLLM elsewhere so we would need to plan and compensate for that.

We use TS in the desktop app actually, so this is not unfamiliar territory to the team by any means but right now we have to weigh the value of doing a total TS overhaul which provides zero value to an end-user vs just building the things that are value add to that same person with the current stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants