Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for reboot 0 broken #325

Closed
fabled opened this issue May 18, 2024 · 1 comment
Closed

Support for reboot 0 broken #325

fabled opened this issue May 18, 2024 · 1 comment
Labels

Comments

@fabled
Copy link

fabled commented May 18, 2024

man dhcpcd.conf says:

reboot seconds
[...]
A setting of 0 seconds causes dhcpcd.conf to skip the reboot phase and go straight into DISCOVER.

Using this configuration now results in indefinite busy loop with the following log output:

wlan0: probing for an IPv4LL address
wlan0: offered 192.168.88.10 from 192.168.88.1
wlan0: failed to request the lease
wlan0: soliciting a DHCP lease
wlan0: probing for an IPv4LL address
wlan0: offered 192.168.88.10 from 192.168.88.1
wlan0: failed to request the lease
wlan0: soliciting a DHCP lease
wlan0: probing for an IPv4LL address
wlan0: offered 192.168.88.10 from 192.168.88.1
wlan0: failed to request the lease
wlan0: soliciting a DHCP lease
wlan0: probing for an IPv4LL address
wlan0: offered 192.168.88.10 from 192.168.88.1
wlan0: failed to request the lease
wlan0: soliciting a DHCP lease
wlan0: probing for an IPv4LL address
wlan0: offered 192.168.88.10 from 192.168.88.1
wlan0: failed to request the lease

Git bisect says this got broken with commit d408e74.

@fabled
Copy link
Author

fabled commented May 18, 2024

Sounds the logic is wrong. Reboot should likely trigger once, but seems the reboot timer gets rescheduled for every request. Would probably be good to just handle reboot 0 immediately instead of via scheduling a timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants