nixos/navidrome: fix settings type #312757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclairevoyant
force-pushed
the
navidrome-fix
branch
from
1ce5bbc
to
3c97088
Compare
eclairevoyant
force-pushed
the
navidrome-fix
branch
from
3c97088
to
a74fd69
Compare
nu-nu-ko
approved these changes
May 18, 2024
|
I tested this on a config which has the following: services.navidrome = {
enable = true;
openFirewall = true;
settings = {
Address = "0.0.0.0";
MusicFolder = "/run/navidrome/media/music";
};
};and verified that the default port is in fact preserved, while the user-set settings are merged in: |
|
This breaks the nixos test, because settings is now required but unset by default. |
mweinelt
added a commit
to r-ryantm/nixpkgs
that referenced
this pull request
May 21, 2024
This will not affect the options, but allows to not configure settings at all, if you don't need to. Unbreaks the NixOS test, which relies on this behavior. Fixes: NixOS#312757
dbalan
pushed a commit
to dbalan/nixpkgs
that referenced
this pull request
May 21, 2024
This will not affect the options, but allows to not configure settings at all, if you don't need to. Unbreaks the NixOS test, which relies on this behavior. Fixes: NixOS#312757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #312749. This fixes merging user-set values with default values.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.