Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: python311Packages.curio (impurity issue?) #312780

Closed
Qyriad opened this issue May 19, 2024 · 2 comments · Fixed by #312874
Closed

Build failure: python311Packages.curio (impurity issue?) #312780

Qyriad opened this issue May 19, 2024 · 2 comments · Fixed by #312874
Labels
0.kind: build failure 2.status: fix-in-staging This issue has been fixed in staging but is not yet in the channels or master 6.topic: python 6.topic: reproducible builds

Comments

@Qyriad
Copy link
Member

Qyriad commented May 19, 2024

Steps To Reproduce

Steps to reproduce the behavior:

  1. nix build 'github:NixOS/nixpkgs/master#python311Packages.curio' --rebuild
  2. Observe that the test tests/test_workers.py::test_cpu fails

Note the --rebuild, as this package is successfully building in Hydra, so I can only assume this is an impurity or non-determinism issue.

Build log

https://gist.github.com/Qyriad/f2387d0fd7ebb61f5270dc6a3d3b544d

Additional context

  • I reproduced this on Nixpkgs commit 68ead29.
  • python312Packages.curio and python310Packages.curio both succeed without issue

Notify maintainers

@pbsds

Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.30, NixOS, 24.05 (Uakari), 24.05.20240517.4a6b83b`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Lix, like Nix) 2.90.0-lixpre20240518-62b1adf
 - nixpkgs: `/nix/store/0aavdx9m5ms1cj5pb1dx0brbrbigy8ij-source`

(Note: it says "Lix" as that's the primary Nix on my system, but I also reproduced this with Nix 2.18 with sudo nix run 'nixpkgs#nixVersions.nix_2_18' -- build 'github:NixOS/nixpkgs/master#python311Packages.curio' --rebuild --store local, so this is certainly not a Lix-specific issue)


Add a 👍 reaction to issues you find important.

@Qyriad
Copy link
Member Author

Qyriad commented May 19, 2024

Build for python39Packages.curio just finished successfully, so this is just failing on 3.11

pbsds added a commit to pbsds/nixpkgs that referenced this issue May 19, 2024
@pbsds
Copy link
Contributor

pbsds commented May 19, 2024

Thank you. I was unable to reproduce even while running stress, but the provided log proved a race condition i found while reading the test. Fixed in #312874

pbsds added a commit to pbsds/nixpkgs that referenced this issue May 19, 2024
@Qyriad Qyriad added the 2.status: fix-in-staging This issue has been fixed in staging but is not yet in the channels or master label May 20, 2024
@pbsds pbsds closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure 2.status: fix-in-staging This issue has been fixed in staging but is not yet in the channels or master 6.topic: python 6.topic: reproducible builds
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants