Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

man-pages: 6.7 -> 6.8 #312813

Merged
merged 1 commit into from
May 21, 2024
Merged

man-pages: 6.7 -> 6.8 #312813

merged 1 commit into from
May 21, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented May 19, 2024 •
edited

The main reason to package snapshot is to pull darwin fix: https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/?id=9524f0f63badd896ccf6da7d79511100d86c4721

Changes: https://lore.kernel.org/linux-man/je5cqtxomjonmjyzdkhalfxr5idkselxxgfybjtwupnocqgaai@hue4yy7hvory/T/#u
Closes: #312797

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

This was referenced May 19, 2024
Closed
Merged
@trofi trofi marked this pull request as draft May 19, 2024 10:15
@trofi
Copy link
Contributor Author

trofi commented May 19, 2024

Let's wait for a 6.8 release today: #300797 (comment)

@alejandro-colomar
Copy link

alejandro-colomar commented May 19, 2024 •
edited

Let's wait for a 6.8 release today: #300797 (comment)

It's already available. ;-)

@trofi trofi changed the title man-pages: 6.7 -> 6.7-unstable-2024-05-14 man-pages: 6.7 -> 6.8 May 19, 2024
@trofi
Copy link
Contributor Author

trofi commented May 19, 2024

Thank you, Alejandro!

Updated the PR to 6.8. Moving from draft to ready for review.

@trofi trofi marked this pull request as ready for review May 19, 2024 14:54
@alejandro-colomar
Copy link 

Reviewed-by: Alejandro Colomar <alx@kernel.org>

:)

Qyriad
Qyriad approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@Qyriad Qyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes #312797

@wegank wegank merged commit b105470 into NixOS:master May 21, 2024
27 of 29 checks passed
@trofi trofi deleted the man-pages-fix-darwin branch May 22, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qyriad Qyriad Qyriad approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: man-pages (Darwin)
4 participants
@trofi @alejandro-colomar @Qyriad @wegank