This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Bug: Order spend panic [ETH] #2012
Assignees
Labels
bug
ethereum
Ethereum integration-related issues.
🔍 readyForReview
Issue or PR ready for code review prior to closing.
Projects
Comments
|
It's clear after reviewing the data that the purchase order used an item and shipping option that charged a few cents for every unit (and there are 10000000000 units), which returned an expected price of ~$1 billion dollars lol. The UPDATE: Using the correct purchase order payload, the test passed.
|
drwasho
added
the
🔍 readyForReview
|
Ran into this panic again after attempting to fetch an order 2 seconds after releasing the funds from escrow: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Context
AWAITING_PAYMENTdue to a problem in thePOST /ob/orderspendcall200 OKbut an empty response... so the problem wasn't handled properly, on top of whatever the problem isThe Problem
To reproduce the problem locally, you'll need to:
Complete moderated online (eth, +options, +shipping, +taxes, +coupons, q=10000000000):This is the order flow of the test:
This is the listing:
{ "listing": { "slug": "physical-eth-options-extras-hiquant", "vendorID": { "peerID": "QmRGCvxohRX7NtAHJ2vziW6DTitCDJxSsJ3QG7GsJeLgpi", "handle": "", "pubkeys": { "identity": "CAESIIGUD8yv0SatWnhIJfmwu+a+BLVJUwH9Ogd24o1IIqh+", "bitcoin": "A9P3boODWa2rCqxS4GUsV7L/2g3Q1SAXtfYprfFWacTi" }, "bitcoinSig": "MEUCIQDhQYRHTwaAb0NrCg59Dme7TBeQTeB+lkyaflV95OOD4QIgPdW++LHapAwciVXWHX6wSlbmCNuczuYAqHv/Dy15c2k=" }, "metadata": { "version": 5, "contractType": "PHYSICAL_GOOD", "format": "FIXED_PRICE", "expiry": "2037-12-31T05:00:00.000Z", "acceptedCurrencies": [ "TBTC", "TBCH", "TLTC", "TZEC", "TETH" ], "pricingCurrency": "", "language": "", "escrowTimeoutHours": 1, "coinType": "", "coinDivisibility": 0, "priceModifier": 0 }, "item": { "title": "Physical, ETH, options, extras", "description": "This is a listing example for testing orders.", "processingTime": "3 days", "price": 0, "nsfw": false, "tags": [ "vintage dress" ], "images": [{ "filename": "front", "original": "QmNexx7SaJCVCjyGGG3j2k7fenn3iVhtWdm9RvKvT7GTLq", "large": "QmfTKL3Z67mWKTKf9XKSCj1ptmDRaZLr5yjPS4JrVDgo5h", "medium": "QmTJfeeapZwFM8EoZAuf16JsSJyxZtKaAR6hmWiMf4CTcF", "small": "QmVsoT9iabv6GZhxhvtjSpQMJA6QyMivGTs6MmHJr6TBm9", "tiny": "QmbjyAxYee4y3443kAMLcmRVwggZsRDKiyXnXus1qdJJWz" }, { "filename": "cream", "original": "QmTEUnCjuQPj1ggj5UL5vJujkgBiNYY4jkteugnogiCJny", "large": "QmNsFdsX2LNALG2WBxw6E6FTPZWgJcRAcLHnKdWczrCNf9", "medium": "QmQaSzaoHzp8raZLtPEFyCjTnwfXvDGKdXFM83STDVWG43", "small": "QmP3BVFuga7N4XEX8iU2MFYC7pc6mfTRQRrpZbKiVy2Csr", "tiny": "QmU1cBgjyHpuzDYbEd4iDVuPzxgKM3CqhRhDJqkHWCKBXq" }, { "filename": "black", "original": "QmZsZ78FJwt281gfeUvGzDnsBW7WNjPWW3aJWDKskhpCRr", "large": "QmXixGseetihe6vZiWcTw9N1pieok1YtRoxwvyd5d7jz6s", "medium": "QmZydpAJoLsJWbP5vmh59W6bW1kuiCV34yD62hq28AtP7b", "small": "QmcADxUo89ZsEAWiYsuUk7hrgjWDMKXL1CtoA9sTNrQFFP", "tiny": "QmdA3Nmc8VnwSvt98Deo2RQztEiCsAkNLhron73bnBzARe" }, { "filename": "other_red", "original": "QmZpgjK4jXmdqPg8Jt9YHGVmiuowVve3sbN2AZx7GXioDF", "large": "QmbSQZNAL3pZspUYWm6WNBD1oEQ6i9EnWPEsnk1DfdKnAv", "medium": "QmcD4pkp7SwCmN95pFnED2hz1LfsoYTPpynxeZbxCMoYPL", "small": "QmRdYph9YrfpdzMsaDnuySj6U4AY9dZhmjd8Cv2e6SscUG", "tiny": "QmbRFtxNWqACak1vvMJrrxUjzWjTJbMqi3vdUK5ZYvibgt" }], "categories": [ "👚 Apparel & Accessories" ], "grams": 0, "condition": "New", "options": [{ "name": "Color", "description": "Color of the dress.", "variants": [{ "name": "Red", "image": { "filename": "front", "original": "QmNexx7SaJCVCjyGGG3j2k7fenn3iVhtWdm9RvKvT7GTLq", "large": "QmfTKL3Z67mWKTKf9XKSCj1ptmDRaZLr5yjPS4JrVDgo5h", "medium": "QmTJfeeapZwFM8EoZAuf16JsSJyxZtKaAR6hmWiMf4CTcF", "small": "QmVsoT9iabv6GZhxhvtjSpQMJA6QyMivGTs6MmHJr6TBm9", "tiny": "QmbjyAxYee4y3443kAMLcmRVwggZsRDKiyXnXus1qdJJWz" } }, { "name": "Cream", "image": { "filename": "cream", "original": "QmTEUnCjuQPj1ggj5UL5vJujkgBiNYY4jkteugnogiCJny", "large": "QmNsFdsX2LNALG2WBxw6E6FTPZWgJcRAcLHnKdWczrCNf9", "medium": "QmQaSzaoHzp8raZLtPEFyCjTnwfXvDGKdXFM83STDVWG43", "small": "QmP3BVFuga7N4XEX8iU2MFYC7pc6mfTRQRrpZbKiVy2Csr", "tiny": "QmU1cBgjyHpuzDYbEd4iDVuPzxgKM3CqhRhDJqkHWCKBXq" } }, { "name": "Black", "image": { "filename": "black", "original": "QmZsZ78FJwt281gfeUvGzDnsBW7WNjPWW3aJWDKskhpCRr", "large": "QmXixGseetihe6vZiWcTw9N1pieok1YtRoxwvyd5d7jz6s", "medium": "QmZydpAJoLsJWbP5vmh59W6bW1kuiCV34yD62hq28AtP7b", "small": "QmcADxUo89ZsEAWiYsuUk7hrgjWDMKXL1CtoA9sTNrQFFP", "tiny": "QmdA3Nmc8VnwSvt98Deo2RQztEiCsAkNLhron73bnBzARe" } }] }, { "name": "Sizes", "description": "Size of the dress.", "variants": [{ "name": "Small" }, { "name": "Medium" }, { "name": "Large" }, { "name": "Extra Large" }] }], "skus": [{ "variantCombo": [ 0, 0 ], "productID": "dress-red-small", "surcharge": 0, "quantity": 0, "bigSurcharge": "0", "bigQuantity": "0" }, { "variantCombo": [ 0, 1 ], "productID": "dress-red-medium", "surcharge": 0, "quantity": 0, "bigSurcharge": "45000000000000", "bigQuantity": "0" }, { "variantCombo": [ 0, 2 ], "productID": "dress-red-large", "surcharge": 0, "quantity": 0, "bigSurcharge": "450000000000000", "bigQuantity": "0" }, { "variantCombo": [ 0, 3 ], "productID": "dress-red-xlarge", "surcharge": 0, "quantity": 0, "bigSurcharge": "450000000000000", "bigQuantity": "0" }, { "variantCombo": [ 1, 0 ], "productID": "dress-cream-small", "surcharge": 0, "quantity": 0, "bigSurcharge": "450000000000000", "bigQuantity": "0" }, { "variantCombo": [ 1, 1 ], "productID": "dress-cream-medium", "surcharge": 0, "quantity": 0, "bigSurcharge": "450000000000000", "bigQuantity": "0" }, { "variantCombo": [ 1, 2 ], "productID": "dress-cream-large", "surcharge": 0, "quantity": 0, "bigSurcharge": "450000000000000", "bigQuantity": "0" }, { "variantCombo": [ 1, 3 ], "productID": "dress-cream-xlarge", "surcharge": 0, "quantity": 0, "bigSurcharge": "450000000000000", "bigQuantity": "0" }, { "variantCombo": [ 2, 0 ], "productID": "dress-black-small", "surcharge": 0, "quantity": 0, "bigSurcharge": "450000000000000", "bigQuantity": "0" }, { "variantCombo": [ 2, 1 ], "productID": "dress-black-medium", "surcharge": 0, "quantity": 0, "bigSurcharge": "450000000000000", "bigQuantity": "0" }, { "variantCombo": [ 2, 2 ], "productID": "dress-black-large", "surcharge": 0, "quantity": 0, "bigSurcharge": "450000000000000", "bigQuantity": "0" }, { "variantCombo": [ 2, 3 ], "productID": "dress-black-xlarge", "surcharge": 0, "quantity": 0, "bigSurcharge": "450000000000000", "bigQuantity": "0" }], "priceModifier": 0, "bigPrice": "450000", "priceCurrency": { "code": "TETH", "divisibility": 18 } }, "shippingOptions": [{ "name": "Worldwide", "type": "FIXED_PRICE", "regions": [ "ALL" ], "services": [{ "name": "Standard", "price": 0, "estimatedDelivery": "3 days", "additionalItemPrice": 0, "bigPrice": "0", "bigAdditionalItemPrice": "0" }, { "name": "Express", "price": 0, "estimatedDelivery": "3 days", "additionalItemPrice": 0, "bigPrice": "450000000000000", "bigAdditionalItemPrice": "1" }] }], "taxes": [{ "taxType": "Sales tax", "taxRegions": [ "AUSTRIA" ], "taxShipping": true, "percentage": 1 }], "coupons": [{ "title": "DASCOUPONPERC", "hash": "QmT1BeeCqZe6FzCKYmhaDzUp2DPefzHeeLfF8sj3Vqnia4", "percentDiscount": 1, "priceDiscount": 0, "bigPriceDiscount": "" }], "moderators": [ "QmcdkKM2fWCKzTZdpjEY6abzRbDhRRJvNmqwNKVyiDtGky" ], "termsAndConditions": "These are my terms and conditions.", "refundPolicy": "This is my refund policy." }, "hash": "QmRThc5zcK3oNMg8YphZqYC1VAQ46hVBZvn1swCWeSBV6T", "signature": "6QdzSiaR4zZPre7vHEjJjmYeNwJVy2CtSdnEcw30u/qwdVumOiaYQD6rt/vWlUn6yJ72YA1WmPTw1Zz06PBMDw==" }This is the purchase order payload:
{ "shipTo": "Elwood Blues", "address": "1060 W Addison", "city": "Chicago", "state": "Illinois", "countryCode": "AUSTRIA", "postalCode": "60613", "addressNotes": "", "items": [ { "listingHash": "QmRThc5zcK3oNMg8YphZqYC1VAQ46hVBZvn1swCWeSBV6T", "bigQuantity": "10000000000", "options": [ { "name": "Sizes", "value": "Large" }, { "name": "Color", "value": "Red" } ], "shipping": { "name": "Worldwide", "service": "Express" }, "memo": "thanks!", "coupons": [ "LETMEIN" ] } ], "moderator": "QmcdkKM2fWCKzTZdpjEY6abzRbDhRRJvNmqwNKVyiDtGky", "paymentCoin": "TETH" }This is the purchase order response:
{ "amount": { "amount": "4499550004954059999999999", "currency": { "code": "TETH", "currencyType": "crypto", "divisibility": 18, "name": "Testnet Ethereum" } }, "orderId": "QmRGWbhcRcdQpk72A4toN56bfe2P6KPApNtdWbDGdsWZrB", "paymentAddress": "0xbB84229770E6Fb560bb531C559e4700fdf228B47", "vendorOnline": true }This is the order spend (
POST /ob/orderspend) payload:{ "currencyCode": "TETH", "address": "0xbB84229770E6Fb560bb531C559e4700fdf228B47", "amount": "4499550004954059999999999", "feeLevel": "NORMAL", "requireAssociateOrder": true, "orderID": "QmRGWbhcRcdQpk72A4toN56bfe2P6KPApNtdWbDGdsWZrB" }The response was:
At the same time, this appeared in stdout:
The text was updated successfully, but these errors were encountered: