Skip to content
This repository has been archived by the owner on Dec 20, 2021. It is now read-only.

Copying by value instead of iterating (d2dcc) #1131

Open
gravestench opened this issue May 31, 2021 · 0 comments
Open

Copying by value instead of iterating (d2dcc) #1131

gravestench opened this issue May 31, 2021 · 0 comments
Labels
Code Cleanup Doesn't materially affect the game
Projects
OpenDiablo 2 Game Engine

Comments

@gravestench
Copy link
Contributor

dcc_direction.go:188
dcc_direction.go:192

the issue here is that cell is a copy of frame.Cells[c]

c := -1

for _, cell := range frame.Cells {
	c++
@gravestench gravestench added the Code Cleanup Doesn't materially affect the game label May 31, 2021
@gravestench gravestench added this to To do in OpenDiablo 2 Game Engine via automation May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Code Cleanup Doesn't materially affect the game
Projects
OpenDiablo 2 Game Engine
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gravestench