Skip to content
This repository has been archived by the owner on Dec 20, 2021. It is now read-only.

Merge d2core/d2gui and d2core/d2ui #861

Open
gravestench opened this issue Oct 28, 2020 · 3 comments
Open

Merge d2core/d2gui and d2core/d2ui #861

gravestench opened this issue Oct 28, 2020 · 3 comments
Labels
Code Cleanup Doesn't materially affect the game Normal Priority For issues that are essential, but are not on the critical path or blocking development in any way

Comments

@gravestench
Copy link
Contributor

We currently have two UI management packages, and no clear indication as to which should be preferred or what their differences are. We really need to merge these two packages into one package.

@gravestench gravestench added Code Cleanup Doesn't materially affect the game Normal Priority For issues that are essential, but are not on the critical path or blocking development in any way labels Oct 28, 2020
@juander-ux
Copy link
Contributor

I can take this one, as I'm cleaning up parts of the ui anyways.

@juander-ux
Copy link
Contributor

I saw that d2gui is only really used by the escape menu. The escape menu with the d2gui system looks over-engineered to me. We get automatic layouts but need to fix them anyways with spacers. Do we really need automatic layouts just to have a little easier time to add items to the escape menu? I'd rather remove the automatic layouts and have a simpler system. Any comments?

@gucio321
Copy link
Contributor

I saw that d2gui is only really used by the escape menu. The escape menu with the d2gui system looks over-engineered to me. We get automatic layouts but need to fix them anyways with spacers. Do we really need automatic layouts just to have a little easier time to add items to the escape menu? I'd rather remove the automatic layouts and have a simpler system. Any comments?

also please note, that in fact escape menu shouldn't use text labels.
it should use sprites instead (they are enumerated in d2resource like EscapeOptions e.t.c.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Code Cleanup Doesn't materially affect the game Normal Priority For issues that are essential, but are not on the critical path or blocking development in any way
Projects
Development

No branches or pull requests

3 participants