Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default server config contains enabled deprecated option cipher #511

Open
TJNII opened this issue Mar 3, 2024 · 3 comments
Open

Default server config contains enabled deprecated option cipher #511

TJNII opened this issue Mar 3, 2024 · 3 comments
Assignees
Labels
documentation documentation only, no code affected patch-submitted There is a patch on the list waiting for merge

Comments

@TJNII
Copy link

TJNII commented Mar 3, 2024

Describe the bug
The default server config contains cipher AES-256-CBC uncommented: https://github.com/OpenVPN/openvpn/blob/master/sample/sample-config-files/server.conf#L252

On start:

2024-03-03 00:51:30 us=398513 DEPRECATED OPTION: --cipher set to 'AES-256-CBC' but missing in --data-ciphers (AES-256-GCM:AES-128-GCM:CHACHA20-POLY1305). OpenVPN ignores --cipher for cipher negotiations.

https://community.openvpn.net/openvpn/wiki/DeprecatedOptions#Policy:Migrateawayfromdeprecatedciphers.Status:Inprogress

This example needs to be updated or removed. Thanks.

@TJNII
Copy link
Author

TJNII commented Mar 3, 2024

This client setting also looks suspicious, I haven't tested this one: https://github.com/OpenVPN/openvpn/blob/master/sample/sample-config-files/client.conf#L116

@cron2
Copy link
Contributor

cron2 commented Mar 3, 2024

Good catch. It will work but is not setting a suitable example for what people should be using. We'll deal with it :-)

@flichtenheld flichtenheld self-assigned this Mar 4, 2024
@flichtenheld
Copy link
Member

Work-in-progress patch here: https://gerrit.openvpn.net/c/openvpn/+/532

@flichtenheld flichtenheld added documentation documentation only, no code affected patch-submitted There is a patch on the list waiting for merge labels Mar 6, 2024
cron2 pushed a commit that referenced this issue Mar 25, 2024
- Remove compression settings. Not recommended anymore.
- Remove old cipher setting. Replaced by data-ciphers negotiation.
- Add comment how to set data-ciphers for very old clients.
- Remove/reword some old comments. e.g. no need to reference
  OpenVPN 1.x anymore.
- Mention peer-fingerprint alternative.
- comment out "tls-auth" as that is not needed for a bare-bones VPN config
  and needs additional setup.

Github: #511
Change-Id: I1a36651c0dea52259533ffc00bccb9b03bf82e26
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Message-Id: <20240325071320.11348-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28451.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
cron2 pushed a commit that referenced this issue Mar 25, 2024
- Remove compression settings. Not recommended anymore.
- Remove old cipher setting. Replaced by data-ciphers negotiation.
- Add comment how to set data-ciphers for very old clients.
- Remove/reword some old comments. e.g. no need to reference
  OpenVPN 1.x anymore.
- Mention peer-fingerprint alternative.
- comment out "tls-auth" as that is not needed for a bare-bones VPN config
  and needs additional setup.

Github: #511
Change-Id: I1a36651c0dea52259533ffc00bccb9b03bf82e26
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Message-Id: <20240325071320.11348-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28451.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit b0fc10a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation only, no code affected patch-submitted There is a patch on the list waiting for merge
Projects
None yet
Development

No branches or pull requests

3 participants