-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p tun configs break with new topology default in non-obvious ways #529
Comments
So if |
But the problem with that check is that it actually uses topology to detect whether we're in P2P mode:
So by changing the default we probably broke this check. |
Nevermind, in current master we do not actually use |
Changing the default only for
|
honestly this feels a bit hacky: i.e. using what we have in a dirty way to properly achieve what we need. How about explicitly adding a TOP_P2P ? after all this is not NET30, but it's a truly different way of assigning the IPs (local+remote vs /30). This way we can then explicitly check if topology == TOP_P2P and act accordingly. |
As discussed on IRC: There is already a |
The setting of --topology changes the syntax of --ifconfig. So changing the default of --topology breaks all existing configs that use --ifconfig but not --topology. For P2P setups that is probably a signification percentage. For server setups the percentage is hopefully lower since --ifconfig is implicitly set by --server. Also more people might have set their topology explicitly since it makes a much bigger difference. Clients will usually get the topology and the IP config pushed by the server. So we decided to not switch the default for everyone to not affect P2P setups. What we care about is to change the default for --mode server, so we only do that now. For people using --server this should be transparent except for a pool reset. Github: #529 Change-Id: Iefd209c0856ef395ab74055496130de00b86ead0 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org> Message-Id: <20240501124254.29114-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28592.html Signed-off-by: Gert Doering <gert@greenie.muc.de>
So the |
@cron2 Please take a look at https://gerrit.openvpn.net/c/openvpn/+/380, my earlier comments seem to indicate that it should improve that part. |
so there's a p2p tun config with
and with commit 32e6586 the new default is now
topology subnet
. This leads to the instance no longer starting, withso it seems "something" is trying to convert the second argument to a netmask/netbits, failing, assigning "-1" to "something" and passing that to sitnl...
This is a config with no
client
orserver
, just plain p2p udp, so it surprised me a bit thattopology
would be relevant here - but quite obviously it changes the interpretation ofifconfig
.So there's two questions here
net30
for point-to-point configs (noserver
)? Which is, of course, much more work than just changing the global default for all...@ordex for the parser, @flichtenheld for the
topology
default.The text was updated successfully, but these errors were encountered: