Feature requests for the configuration file related to the Email option

[MsJamie]

PrivateBin version: 1.5.0

I'd like to request two features via configuration flags

1. Option to disable the Email button like can be done with QR Codes
2. An option to automatically generate a short URL.

• A. Replacing the paste link (without hitting a button)
• B. Also replacing the URL in the browser window on successful paste save (if possible)

Not related to this request but is there an alternative way to donate to the project other than cryptocurrency?

[elrido]

These might be some good first issues for someone that would like to familiarize themselves with the javascript code. I can give some hints if anyone would like to pick this up.

AFAIK the project doesn't take any form of donations right now, other than code contributions ;-) and free tier offerings of webservices (like this github project site here or the project websites), and in particular we don't accept or have ever accepted cryptocurrency. I had looked into applying for the github sponsor system, but it requires to have an organization in certain countries of the world and neither of these would have applied to the project in it's current state.

[rugk]

Also I'd ask you to create one issue per feature request/separate idea. That said, your second idea is, however, already tracked in #833, which you can upvote if you want to support it, and as such I focus this issue on your first idea.

[Alessandro-Battiato]

Greetings!
I can see you flagged this as a good first issue, but I'm a bit confused as of what's the task, is it now only about adding a functionality to disable the email button using JavaScript?

[elrido]

Yes, I think that this would only be about this one point:

1. Option to disable the Email button like can be done with QR Codes

To provide you some pointers on how this is all tied together, you can track how the qrcode option works - I hope this doesn't kill the fun of the task, treat this as your spoiler warning:

New configuration options, commented or otherwise, in conf.sample.php will only get picked up if a default value is added to the Configuration class:

PrivateBin/cfg/conf.sample.php

Lines 64 to 66 in e84a869

	; (optional) Let users create a QR code for sharing the paste URL with one click.
	; It works both when a new paste is created and when you view a paste.
	; qrcode = true

PrivateBin/lib/Configuration.php

Line 55 in e84a869

'qrcode' => true,

This is then injected into the template file's environment in:

PrivateBin/lib/Controller.php

Line 413 in e84a869

$page->assign('QRCODE', $this->_conf->getKey('qrcode'));

And the templates can use it to remove the modal window (only in the bootstrap template) and button from the HTML (note the email ones right next to it):

PrivateBin/tpl/bootstrap.php

Lines 126 to 148 in e84a869

	<?php
	if ($QRCODE) :
	?>
	<div id="qrcodemodal" tabindex="-1" class="modal fade" aria-labelledby="qrcodemodalTitle" role="dialog" aria-hidden="true">
	<div class="modal-dialog" role="document">
	<div class="modal-content">
	<div class="modal-body">
	<div class="mx-auto" id="qrcode-display"></div>
	</div>
	<div class="row">
	<div class="btn-group col-xs-12">
	<span class="col-xs-12">
	<button type="button" class="btn btn-primary btn-block" data-dismiss="modal"><?php echo I18n::_('Close') ?></button>
	</span>
	</div>
	</div>
	</div>
	</div>
	</div>
	<?php
	endif;
	?>
	<div id="emailconfirmmodal" tabindex="-1" class="modal fade" aria-labelledby="emailconfirmmodalTitle" role="dialog" aria-hidden="true">

PrivateBin/tpl/bootstrap.php

Lines 219 to 227 in e84a869

	<button id="emaillink" type="button" class="hidden btn btn-<?php echo $isDark ? 'warning' : 'default'; ?> navbar-btn">
	<span class="glyphicon glyphicon-envelope" aria-hidden="true"></span> <?php echo I18n::_('Email'), PHP_EOL; ?>
	</button>
	<?php
	if ($QRCODE) :
	?>
	<button id="qrcodelink" type="button" data-toggle="modal" data-target="#qrcodemodal" class="hidden btn btn-<?php echo $isDark ? 'warning' : 'default'; ?> navbar-btn">
	<span class="glyphicon glyphicon-qrcode" aria-hidden="true"></span> <?php echo I18n::_('QR code'), PHP_EOL; ?>
	</button>

PrivateBin/tpl/page.php

Lines 132 to 139 in e84a869

	<button id="emaillink" class="hidden"><img src="img/icon_email.png" width="15" height="15" alt="" /><?php echo I18n::_('Email'); ?></button>
	<?php
	if ($QRCODE):
	?>
	<button id="qrcodelink" class="hidden"><img src="img/icon_qr.png" width="15" height="15" alt="" /><?php echo I18n::_('QR code'); ?></button>
	<?php
	endif;
	?>

[Alessandro-Battiato]

Thanks for taking your time to explain my question, but I apologize in advance as I think I don't have the necessary knowledge to work on your project as I was convinced for some reason that only JavaScript was used, I have no knowledge of PHP whatsoever, but thanks anyway for the explanation I'm sure it'll come in handy for someone else who can work with this :)