Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: (Torznab) Add `magneturl' attribute #1800

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mynameisbogdan
Copy link
Contributor

@mynameisbogdan mynameisbogdan commented Jul 27, 2023

Database Migration

NO

Issues Fixed or Closed by this PR

@mynameisbogdan mynameisbogdan force-pushed the torznab-magneturl branch 3 times, most recently from c950098 to d397e73 Compare July 28, 2023 04:07
@github-actions github-actions bot added the Area: Indexer Issue is related to indexers. label Jul 28, 2023
@mynameisbogdan mynameisbogdan changed the title New: (Torznab) Add magneturl to search response New: (Torznab) Add Prefer Torrent File option Jul 28, 2023
@mynameisbogdan mynameisbogdan changed the title New: (Torznab) Add Prefer Torrent File option New: (Torznab) Add Prefer Magnet URL option Jul 28, 2023
@github-actions github-actions bot removed the Area: Indexer Issue is related to indexers. label Aug 5, 2023
@mynameisbogdan mynameisbogdan added the Status: Don't Merge Hold up - don't merge this label Aug 5, 2023
@mynameisbogdan mynameisbogdan marked this pull request as draft August 5, 2023 15:49
@mynameisbogdan mynameisbogdan force-pushed the torznab-magneturl branch 4 times, most recently from 80ef20d to c3ffb4c Compare September 4, 2023 07:52
@github-actions github-actions bot added the Area: API Issue is related to the API label Sep 4, 2023
@mynameisbogdan mynameisbogdan marked this pull request as ready for review September 4, 2023 07:53
@Qstick
Copy link
Contributor

Qstick commented Sep 4, 2023

The way this is done now means no magnet grab will ever get recorded to history in Prowlarr right? Also what happens for results that only have Magnet? Link won't be populated

@mynameisbogdan
Copy link
Contributor Author

The way this is done now means no magnet grab will ever get recorded to history in Prowlarr right? Also what happens for results that only have Magnet? Link won't be populated

Well if the arrs will prefer the magneturl attribute, then yes, no grab history for those.

The link will be always populated, I just moved the logic from Results to Controller to I can have MagnetUrl unproxied.

Overall, that's why I postponed this PR. It's either these changes or Prefer magnet URLs in the Generic Torznab.

@mynameisbogdan mynameisbogdan changed the title New: (Torznab) Add Prefer Magnet URL option New: (Torznab) Add `magneturl' attribute Sep 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API Issue is related to the API Status: Don't Merge Hold up - don't merge this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to prefer magnet links for torrents
2 participants