Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

Rework Advancements so Categories are just a name, not a definition of type. #536

Open
JMCY26 opened this issue Jun 20, 2019 · 1 comment
Labels
enhancement Also known as new features. help wanted Contributions welcome!

Comments

@JMCY26
Copy link

JMCY26 commented Jun 20, 2019

This is a big ask, Is it possible so Categories are just names, and advancements made under those names in the config show up in that category in the GUI but aren't all the same type of achievement goal? It's a big ask but let me explain.

Currently, each Category is defined by Places, Breaks, Kills etc. But what if categories are just names and have no attachment to the type of achievement?

That way I can have a category filled with different types of achievements, requiring different goals, Kill/Eat/Craft. Rather than each of these being in their own set categories.

Example being:
Farming:
beetroots:
'15':
Style: Breaks
Goal: Plant 15 Beetroots.
Message: You planted 15 Beetroots!
Name: place_15_beetroot
DisplayName: §a[Turn up the Beet!]&f - Plant 15 Beetroots.
sugar_cane:
'15':
Style: Places
Goal: Plant 15 Sugar Cane.
Message: You planted 15 Sugar Cane!
Name: place_15_sugarcane
DisplayName: §a[Sugar me up!]&f - Plant 15 Sugarcane.

That way I can have a category in /aa list showing these two achievements in the same category, but one is a placement type, and one is a breaks.

Maybe a possible thing in the future should you ever decide to overhaul the plugin? as I suspect that's a big core change of the plugin. But it would allow us to really make our own choices in each category. That way we could also make NEW categories, which are just names and don't require being fixed to a specific type.

@PyvesB PyvesB added enhancement Also known as new features. help wanted Contributions welcome! labels Jun 23, 2019
@PyvesB
Copy link
Owner

PyvesB commented Jun 23, 2019

Hello @JMCY26,

As you've well understood, it would require a lot of work and would probably impact existing users. I'm open to the idea though and would be happy to review a contribution, but I don't plan on working on it myself anytime in the near future. 😉

Cheers,

Pyves

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Also known as new features. help wanted Contributions welcome!
Projects
None yet
Development

No branches or pull requests

2 participants