Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Use eng files to define additional motor parameters #600

Open
chasgior214 opened this issue May 15, 2024 · 2 comments
Open

ENH: Use eng files to define additional motor parameters #600

chasgior214 opened this issue May 15, 2024 · 2 comments
Labels
Enhancement New feature or request, including adjustments in current codes Motors Every propulsion related issue or PR

Comments

@chasgior214
Copy link

Is your feature request related to a problem? Please describe.

It would be nice to not have to write out motor parameters that are already defined in an eng file when using an eng file to supply the thrust curve for a motor.

#309 addressed automatically adding the burnout time, but it did not implement that for the GenericMotor class. An additional variable that can be read from an eng file is the dry weight (the first line of an eng file specifies propellant mass and loaded/total mass (source), dry mass being the difference) for any motor class, and the initial mass for the GenericMotor class.

It could make RocketPy an easier tool to use to quickly compare how a rocket would perform using different motors, similar to Thrust Curve's motor guide but with a more advanced flight simulator.

Describe the solution you'd like

  1. The GenericMotor class gets the same update that the other motor classes did in Auto burn out time #309
  2. All motor classes that have a thrust curve defined by an eng file have their dry masses defined by the eng file by default (a user-supplied dry mass would override that value)
  3. The GenericMotor class has its propellant_initial_mass parameter defined by the eng file by default (a user-supplied propellant mass would override that value)
@Gui-FernandesBR
Copy link
Member

This is a good suggestion. @chasgior214 would you like to participate on the solution too?
We can guide you through the implementation.

@chasgior214
Copy link
Author

Sure! I've never used pull requests or contributed to a large project before, so apologies in advance if I mess something up lol. Where should I get started?

@Gui-FernandesBR Gui-FernandesBR added Enhancement New feature or request, including adjustments in current codes Motors Every propulsion related issue or PR labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request, including adjustments in current codes Motors Every propulsion related issue or PR
Projects
Status: Backlog
Development

No branches or pull requests

2 participants