Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that probes have satisfactory timing levels #593

Open
mattcolegate opened this issue Jun 17, 2019 · 0 comments
Open

Check that probes have satisfactory timing levels #593

mattcolegate opened this issue Jun 17, 2019 · 0 comments

Comments

@mattcolegate
Copy link
Member

Issue #590 was caused by the http(s) probes using the timing contexts at the functional level (stored in aspect.js). This is fine for probes that can expect big enough gaps in their event flow that the events pass singularly through the instrumented function, but not for probes whose events are rapid. The probes should be examined for speed, and if necessary have their own timing contexts stored at the individual request level to prevent clashes of timing data. This may require the wholesale removal of the context object from aspect.js, which would require thorough testing as it would constitute a change to the underlying framework of Appmetrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant