Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize Rendering #38

Open
agrippa1994 opened this issue Jun 14, 2017 · 1 comment
Open

Centralize Rendering #38

agrippa1994 opened this issue Jun 14, 2017 · 1 comment

Comments

@agrippa1994
Copy link
Member

At the moment the overlay code is redundant in this repository and also here: https://github.com/agrippa1994/DX9-Overlay-API

We should think about centralizing all rendering functions in one git module. However, we do not need to adjust the code in both repository if a bug or feature in the Overlay API is fixed / developed.

@shadowlif what do you think about?

@ghost
Copy link

ghost commented Jun 15, 2017

I think it's better to remove the rendering component from this API completely, because atm there's no feature in the rendering component that requires the other API components.
Also if we remove the rendering component, the DX9API have no compatibility issues with this API anymore (e.g. two softwares, one with this API, one with the DX9API, if both run simultaneously, only one can create an overlay).
So I think it's better to have an general and compact DX9API.

Also, if you need to have an other rendering function for SAMP in the DX9API, you can implement this also at runtime if needed. So you check if there is e.g. and custom rendering hook for this application. If so, just load it up. If there is no custom rendering for this application you just can use the general one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant