Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: Content deployment - Invalid webapps in content.zip #22

Open
IObert opened this issue Feb 5, 2020 · 1 comment
Open

Example: Content deployment - Invalid webapps in content.zip #22

IObert opened this issue Feb 5, 2020 · 1 comment

Comments

@IObert
Copy link

IObert commented Feb 5, 2020

It seems that all web apps in https://github.com/SAP-samples/cf-mta-examples/tree/master/content-deployment/content specify destinations in the xs-app.json file. If these destinations are not set up, the webapps cannot be used as the approuter will throw an exception.

So the sample is ok if it should only be used to demonstrate the cf deploy ./ but it's not suited to show how to use the html5 app repo.

My ask would be to remove the destinations from the xs-app.json files

@IObert IObert changed the title Example: Content deployment Example: Content deployment - Invalid webapps in content.zip Feb 5, 2020
@ddonchev
Copy link
Contributor

ddonchev commented Feb 5, 2020

Good point @IObert,
It does make sense to demonstrate with working examples - makes it much more tangible.
I'm leaving the issue opened until the example is fixed.
Thanks for debugging and sharing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants