Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo is not filtering Vanilla Enchanted Books (All treated as same with/without Lore filter) #3341

Open
4 tasks done
NathZen opened this issue Nov 6, 2021 · 11 comments · May be fixed by #4190
Open
4 tasks done

Cargo is not filtering Vanilla Enchanted Books (All treated as same with/without Lore filter) #3341

NathZen opened this issue Nov 6, 2021 · 11 comments · May be fixed by #4190
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team.

Comments

@NathZen
Copy link

NathZen commented Nov 6, 2021

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

Cargo doesn't fillter Enchanted Books per enchant. All Enchant were merged into 1 chest that has any enchanted book filter in it

📑 Reproduction Steps

  1. Place the chest and fill it with several different enchanted books
  2. Connect the Cargo Node (Input) to the chest and enable the blacklist in it.
  3. Place some chest and connect the Advanced Cargo Node (Output) to it
  4. Insert 1 type of enchanted book per cargo on each chest into the whitelist filter.

💡 Expected Behavior

The cargo distinguish the Enchanted Book

📷 Screenshots / Videos

No response

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.16.x

⭐ Slimefun version

image

🧭 Other plugins

No response

@NathZen NathZen added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🐞 Bug Report A bug that needs to be fixed. labels Nov 6, 2021
@variananora variananora added 🧨 Confirmed Bug This bug has been confirmed by our team. and removed 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels Nov 6, 2021
@kylemarham
Copy link

Can this bug be reviewed please? 13 months later no update.

@Boomer-1
Copy link

there is no issue here. They work fine. I've had a setup for over a year going from level 3 to 15 and not once had an issue

@Boomer-1
Copy link

if you can provide video evidence of it not working i will leave this open. All node configurations must be captured clearly, showing every setup and book in each one,, and verification the nodes are connected to the cargo network,

@kylemarham
Copy link

Please see the below link

https://streamable.com/zs5ssd

The expected behaviour is that Smite 4 is inserted into the Advanced Cargo Node (Output), but the cargo node feeds Smite 3 books into the book binder instead.

@Boomer-1
Copy link

Their server is 6 months behind. Ill leave this open waiting on confirmation of the issue on dev 1035.

@kylemarham
Copy link

Can confirm this is still an issue on version 1035

https://streamable.com/r05bnm

@J3fftw1
Copy link
Member

J3fftw1 commented Jan 21, 2023

I think the best way to solve this issue is to add a same enchant filter instead of a lore check.
Enchants arent really lore so we have to check it differently aswell
If we go this route we could just make it if there are 2 enchants it will just choose between 1 if thats filtered.
If anyone can think of another option throw it in the comments.

@Phoenix-Starlight
Copy link
Member

Phoenix-Starlight commented Jan 22, 2023 via email

@J3fftw1
Copy link
Member

J3fftw1 commented Jan 22, 2023

okay i will give it a look

@Boomer-1
Copy link

if more than 1 enchantment, maybe bypass it. Most players when sorting enchantment books put the same in one storage. If i'm sorting eff 5, and i have a second book that's eff 5 mending, unb 3, i'd want it to not go in with the eff 5 books.

@kylemarham
Copy link

kylemarham commented Jan 31, 2023

Can NBT data not be used when the cargo nodes encounter the minecraft:enchanted_book item?

If item in filter is enchanted_book and has NBT data, check NBT data for a match, if it matches, allow the item through?

From what I can see from looking through the plugin, it looks like potions are already handled the way that enchanted books should be.

image

@Intybyte Intybyte linked a pull request May 13, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants