Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer applications need to inspect ClientServersAvailable or be notified when a ClientServerUnavailable occurs #1001

Open
azuisleet opened this issue Jul 1, 2021 · 4 comments

Comments

@azuisleet
Copy link
Member

On June 30th cm1-ord1.cm.steampowered.com started rejecting PICS requests. Our consumers don't know this is happening because the two mechanisms to handle this aren't exposed.

We need to expose one or both of these so consumers can reconnect to a new CM.

Here's a malfuctioning server:
image

And here's a functioning server:
image

@azuisleet
Copy link
Member Author

I have implemented the simple path here: 0c9290f

We will abort the connection and mark the server as failed when we see a ClientServerUnavailable.

As part of that, we will also shuffle the endpoint list so we don't keep hitting the same CM: 90c2847

@xPaw
Copy link
Member

xPaw commented Jul 2, 2021

I wonder, does this unavailable response come when you send a emsg to an unavailable server? If so, does that mean the emsg and jobid match?

@azuisleet
Copy link
Member Author

ClientServerUnavailable includes the correct emsg and jobid for the request (ClientPICSChangesSince in this example)

@azuisleet
Copy link
Member Author

The shuffle logic has been revised to instead mark all endpoints by host: d8a1f8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants