Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespaces in Nitrox.Test to match folder structure #2017

Open
Measurity opened this issue Apr 8, 2023 · 0 comments
Open

Fix namespaces in Nitrox.Test to match folder structure #2017

Measurity opened this issue Apr 8, 2023 · 0 comments
Labels
Area: dev Related to development environment Complexity: easy Suitable for contributors new to Nitrox Type: enhancement Issue is to be solved by implementing new features

Comments

@Measurity
Copy link
Collaborator

Measurity commented Apr 8, 2023

Why?

  • Resharper warns to adjust namespaces if they don't match the folder structure. There's even a refactoring option to adjust the namespaces of an entire project to match the folders. If we applied this refactoring now, it would break our namespace convention in Nitrox.Test.
  • There doesn't seem to be an option do disable the resharper namespace check on a per project basis.

When?

Since renaming folders effectively moves the code files this change requires planning to not cause merge-conflicts for other developers. It should be done closer to a release (candidate) of Nitrox.

How to fix

  1. Set root namespace of Nitrox.Test to empty:
    image
  2. Rename the folders to match the project namespaces it tests: Model -> NitroxModel
    image
@Measurity Measurity added Type: bug Complexity: easy Suitable for contributors new to Nitrox Area: dev Related to development environment labels Apr 8, 2023
@Measurity Measurity added Type: enhancement Issue is to be solved by implementing new features and removed Type: bug labels Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: dev Related to development environment Complexity: easy Suitable for contributors new to Nitrox Type: enhancement Issue is to be solved by implementing new features
Projects
None yet
Development

No branches or pull requests

1 participant