Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voice-chat volume indication #1398

Open
EntranceJew opened this issue Feb 9, 2024 · 5 comments
Open

voice-chat volume indication #1398

EntranceJew opened this issue Feb 9, 2024 · 5 comments
Labels
type/feature New functionality
Milestone

Comments

@EntranceJew
Copy link
Contributor

Is your feature request related to a problem? Please describe.

It is difficult to tell when audio is transmitting through local player's microphones.
It is difficult to tell when other people are holding the talk button or transmitting voice.

Describe the solution you'd like

A FFT visualization (even if faked) of the voice volume activity.
image
This gives several visual cues for the voice activity:

  • Transparency continues to act as a cue for raw voice receive volume.
  • A new FFT visualizer of some form indicates transmit and receive microphone volume, even if faked heavily.
  • Never flatline, so that people can still keep their transmission ambiguous with proximity voice enabled. Simulate some low threshold of activity.
  • Force FFT visualizer to indicate extremely low amplitude if distance is extremely great.

Describe alternatives you've considered

semaphores

Additional context

i wish gmod had a way to control proximity voice server-sided

@TimGoll
Copy link
Member

TimGoll commented Feb 9, 2024

Is there a FFT in GMod or would we need to use an external library for that?

Also I think this should be combined with moving this element to our HUD system first imho. One of the reason we didn't do it in the past was because of the player icon. But we have systems for that by now, so it would be easy to do

@TimGoll TimGoll added keepalive type/feature New functionality labels Feb 9, 2024
@TimGoll
Copy link
Member

TimGoll commented Feb 9, 2024

image

maybe the UI can also be a bit like this OBS discord plugin

@EntranceJew
Copy link
Contributor Author

addons like these handle it, i recall seeing a million darkrp servers doing it, a FFT is pretty inexpensive, i handed off a lot of my old FFT code to the OSU! dev; but even these look simple:
https://github.com/SupinePandora43/VoiceVisualizer/tree/master
https://steamcommunity.com/sharedfiles/filedetails/?id=1825794230

@EntranceJew
Copy link
Contributor Author

maybe the UI can also be a bit like this OBS discord plugin

if that's what you like, Kuma's already got one: https://steamcommunity.com/sharedfiles/filedetails/?id=1469659378, but I personally find it easier to diagnose particular problems with my microphone with either meters or a waveform

@TimGoll
Copy link
Member

TimGoll commented Feb 9, 2024

maybe the UI can also be a bit like this OBS discord plugin

if that's what you like, Kuma's already got one: https://steamcommunity.com/sharedfiles/filedetails/?id=1469659378, but I personally find it easier to diagnose particular problems with my microphone with either meters or a waveform

I though about a nice looking element combined with your idea of the audio bars

@TimGoll TimGoll added this to the v0.14.0b milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature New functionality
Projects
None yet
Development

No branches or pull requests

3 participants