Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify IsAdmin and IsSuperAdmin use #1426

Open
TimGoll opened this issue Feb 19, 2024 · 0 comments
Open

Unify IsAdmin and IsSuperAdmin use #1426

TimGoll opened this issue Feb 19, 2024 · 0 comments
Labels
type/rework Big changes or overhaul of an existing feature

Comments

@TimGoll
Copy link
Member

TimGoll commented Feb 19, 2024

Currently we sometimes use ply:IsAdmin and sometimes ply:IsSuperAdmin. Most notably, the scoreboard shows the admin icon even for normal admins, while all admin settigs are only visible for superadmins. This leads to confusion.

Besides that, we should probably replace all IsAdmin calls with IsSuperAdmin anyway. There is no point to allow admins to change convars, when the UI is only shown to super admins
@Histalek Histalek added the type/rework Big changes or overhaul of an existing feature label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/rework Big changes or overhaul of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimGoll @Histalek