Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to edit voice chat range #1482

Closed
Spieler2301 opened this issue Mar 10, 2024 · 3 comments
Closed

Option to edit voice chat range #1482

Spieler2301 opened this issue Mar 10, 2024 · 3 comments
Labels
type/enhancement Enhancement or simple change to existing functionality
Milestone

Comments

@Spieler2301
Copy link

My ttt group is currently really interested in using the ingame voice chat instead of discord (or simmilar). But we noticed that the range of a players voice is relatively short, and that ttt2 doesnt seem to add an option to adjust it

I think a good and modular approach would be a 2 slider system. One to define a small range where a players voice stays at a consistent 100%. And a second one to define the range where a players voice can no longer be heared. (Between those two point the loudness could just drop linearly. This approach would probably need a small description next to the second slider that reminds the player what the default 100 to 0 distance is. If, by default, a players voice cant be heared after more than 800 hammer units, the tooltip could remind the player to keep the distance between slider 1 and 2 at roughly 800.)

Alternative Solution:
If this approach turns out to be to complicated for users to understand, a more straight forward but less interesting solution could be to just add the first slider to define the area where the voice stays at 100%. (After that range, the voice drop off could stay the same as it currently is.)

@TimGoll TimGoll added the type/enhancement Enhancement or simple change to existing functionality label Mar 10, 2024
@TimGoll TimGoll added this to the v0.14.0b milestone Mar 10, 2024
@TimGoll
Copy link
Member

TimGoll commented Mar 10, 2024

This is definitely something I will consider in my current voice chat rework for v0.14.0! Thanks!

@EntranceJew
Copy link
Contributor

fwiw the can-hear hook that SMORE uses for this can only diminish the audible range of speaking and cannot increase the base range

to implement the sliders it would be ideal to use a 0 to 1 scale against the SetVolume scale actively against the preferrential volume that is already assigned so that there is not a sharp cutoff like SMORE's implementation

i'm not certain how taxing an implementation like this would be but there is very little one can do to do this without a dll, but it should NOT be done in the canhearplayer hook because it is called way too often, this should be done in Think or slower

the reasoning is that voice playing during post-round from a spectator or from a player no longer nearby will still receive at full volume for up to two seconds afterward

also look into DarkRP's spatial canhear hook because a simple optimized blocked distance check is insufficient, as occasionally out of range players still within the PAS will be audible from 0,0,0 and suffice to say it will never be fixed

@TimGoll
Copy link
Member

TimGoll commented Apr 11, 2024

Sadly, I don't think this is possible as discussed here: #1491 (comment)

If someone has any idea how to implement the request I'm all for it as I'd like to have that as well. But for now I'll close this as I don't think we can do anything about that

@TimGoll TimGoll closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement or simple change to existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants