Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting for the range of Note Display Mode #420

Open
Revanee opened this issue May 11, 2023 · 2 comments
Open

Setting for the range of Note Display Mode #420

Revanee opened this issue May 11, 2023 · 2 comments

Comments

@Revanee
Copy link

Revanee commented May 11, 2023

Issue type: Feature request

Actual behavior

Currently, when using any Note Display Mode, the notes have a limited range of pitch.
This causes notes outside of that range to wrap around, making it confusing to understand if
the next note is higher or lower.

For example:

This is what it looks like:       This it what is actually happening:
                                  ----0-
-0----                            -0----
------                            ------
----0-                            ------

Expected behaviour

It would be nice to be able to see the full range of notes in a song so that higher notes are always
higher visually. Mabe with a setting that makes the Note Display take up the whole vertical space of the
screen with the range being determined by the range of the song. Alternatively, color coding the notes
by octave could also work as a visual indicator of the actual pitch of the notes.

@achimmihca
Copy link
Collaborator

The presentation of the note pitch is something that bothers me as well.
But I am unsure how to improve this.

Currently, notes are wrapped because the singing pitch is wrapped for scoring.
However, presentation could still use some rules to be similar to the target note pitch.

There have also been some ideas to connect notes with a slide, but these have been dropped due to wrapping of notes: #253

@Revanee
Copy link
Author

Revanee commented May 18, 2023

I experimented a bit and came up with this patch.

It recalculates the line count based on the range of a song. This way higher notes are always higher up. It wouldn't look great in a song with a range of something like 3+ octaves, but I think it's much better than not seeing if a note should be higher or lower.
The patch itself would probably mess with other stuff, but I think this approach could work.

Regarding scoring, maybe something like showing the player's pitch on every octave could be an idea? It would look something like this with the true pitch highlighted:

----------------------------------------
----ooooooooooooooooooo--oooooo---------
-ooo-----------------------------ooo----
----------------------------------------
----------------------------------------
----0000000000000000000--000000---------
-000-----------------------------000----
----------------------------------------
----------------------------------------
----ooooooooooooooooooo--oooooo---------
-ooo-----------------------------ooo----
----------------------------------------

Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants