Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UScreenSingView: fix uninitialized float being used #788

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

s09bQ5
Copy link
Collaborator

@s09bQ5 s09bQ5 commented Dec 20, 2023

It sometimes upsets the range checking enabled with fpc's -Ciro.

Fixes #786

It sometimes upsets the range checking enabled with fpc's -Ciro.
Copy link
Collaborator

@barbeque-squared barbeque-squared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that will fix it, I'm not unfamiliar with this change. Though, I was kinda hoping to first figure something out that would give us proper stacktraces before fixing the things (but I will admit this intention wasn't very clear from the original ticket).
I know there's a way to get it from the address or something, but unless it's some magic fpc command I'd rather it be a bit more developer-friendly.

(I'll merge it before the end of the year regardless of whether we have this stacktracing thing figured out though, so that it gets into the next release)

@barbeque-squared
Copy link
Collaborator

Since we have stacktracing figured out now, there's no reason to postpone merging this anymore. I will manually reopen #786 after merging though, because with this fix I immediately got other errors one or two screens later.

@barbeque-squared barbeque-squared merged commit 174444f into UltraStar-Deluxe:master Dec 24, 2023
1 check passed
@s09bQ5 s09bQ5 deleted the fix-range-error branch December 28, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding -Ciro breaks Linux
2 participants