Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all portTICK_PERIOD_MS #466

Open
2 of 7 tasks
trombik opened this issue Oct 26, 2022 · 1 comment
Open
2 of 7 tasks

remove all portTICK_PERIOD_MS #466

trombik opened this issue Oct 26, 2022 · 1 comment
Assignees

Comments

@trombik
Copy link
Collaborator

trombik commented Oct 26, 2022

The issue

portTICK_PERIOD_MS has been deprecated. they should be replaced with pdMS_TO_TICKS.

Which SDK are you using?

esp-idf

Which version of SDK are you using?

master

Which build target have you used?

  • esp32
  • esp32s2
  • esp32s3
  • esp32c2
  • esp8266
  • other

Component causing the issue

see below

Anything in the logs that might be useful for us?

ack --files-with-matches portTICK_PERIOD_MS
components/bme680/bme680.c
components/ccs811/README.md
components/ds18x20/ds18x20.c
components/led_strip_spi/led_strip_spi.c
components/mhz19b/README.md
components/mhz19b/mhz19b.c
components/sht3x/sht3x.c
components/si7021/si7021.c
docs/porting.md
docs/source/groups/ccs811.rst
examples/ls7366r/default/main/main.c
examples/mhz19b/default/main/main.c

Additional information or context

No response

Confirmation

  • This report is not a question nor a request for drivers.
@trombik trombik self-assigned this Oct 26, 2022
trombik added a commit to trombik/esp-idf-lib that referenced this issue Nov 14, 2022
portTICK_PERIOD_MS has been deprecated.

fixes UncleRus#466
@nopnop2002
Copy link
Contributor

nopnop2002 commented Dec 11, 2022

portTICK_PERIOD_MS has been deprecated.

No.
portTICK_PERIOD_MS is not deprecated.

The units and purpose of portTICK_PERIOD_MS and pdMS_TO_TICKS are different.

The purpose of portTICK_PERIOD_MS is to provide a conversion factor for converting milliseconds to ticks.
The unit of portTICK_PERIOD_MS is milliseconds/ticks

The purpose of pdMS_TO_TICKS is to convert milliseconds to ticks.
The unit of pdMS_TO_TICKS is ticks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants