Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ideas #673

Closed
kristiker opened this issue Nov 21, 2023 · 3 comments
Closed

Refactor ideas #673

kristiker opened this issue Nov 21, 2023 · 3 comments
Labels

Comments

@kristiker
Copy link
Member

kristiker commented Nov 21, 2023

  • IKeyValueCollection ContainsKey(k) && GetProperty(k) -> GetValueOrDefault(k) like in ParticleDefinitionParser
  • LoadFile(file+ "_c") -> LoadFileCompiled(file)
@xPaw
Copy link
Member

xPaw commented Nov 30, 2023

Renderer: try to run update of both normal and skybox scenes before renderer, then try to also do all morph rendering before main rendering.

@xPaw
Copy link
Member

xPaw commented Jan 22, 2024

Replace rawVertices float array and EnsureSpaceForVertices in particle renderer with ArrayPool.Shared.

EDIT: done

@xPaw
Copy link
Member

xPaw commented Feb 20, 2024

Refactor particles trails/sprites to have more in common, then merge the separate shaders into one spritecard shader.

@xPaw xPaw closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants