1.20.4 Hover Event Sanitization

[valaphee]

/viaversion dump Output

Latest commit of ViaVersion 0d788b0

Console Error

Not applicable

Bug Description

With 1.20.3+ and the usage of nbt for chat components, the entity hover event's type identifier seems to require a lower case but servers running any other version could still use upper case identifiers which would disconnect any client newer than 1.20.3.

https://i.imgur.com/jEfTRyi.png
https://i.imgur.com/aPoG3ja.png
https://i.imgur.com/4ZcYN8Z.png

Steps to Reproduce

1. Send a message with a hover event (/tellraw)
2. Observe the clients behavior in 1.20.2 vs 1.20.3+

Expected Behavior

The hover event should work properly and not cause a disconnect.

Additional Server Info

Paper 1.8.9

Checklist

• Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. BungeeCord), not on both.
• I have included a ViaVersion dump.
• If applicable, I have included a paste (not a screenshot) of the error.
• I have tried the latest build(s) from https://ci.viaversion.com/ and the issue still persists.

[Barvalg]

[valaphee]

Its also weird that mcstructs doesn't catch this error as there is a check that the name has to be lc, but it somehow passes through.

But there should also be a more sophisticated conversion for hover event entity type, as for example pigman -> piglin conversion is also not applied, etc.

[MrTommyt]

Any ETA on when this problem would be fixed? I've seen other issues that can fall under this one already opened and they've all been opened from long ago, is this being planned to be fixed anytime soon?

[prxgma]

Do we have an ETA on this yet? Or just any update on this further? I am experiencing issues with this as well and it's been a rather consistent and disruptive issue.

[FlorianMichael]

@valaphee The reason MCStructs doesn't catch this error is that this is nothing related to the structure of the component, MCStructs doesn't validate components for their validation in terms of the client's ability to read them, it only validates the structure of a component. VV is missing string id/name conversions in components in general, this also applies to show_item where the id tag is never converted causing items to be invalid in most version ranges. I'll look at this issue next time I work on components once I am done with some other stuff.