Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#AUDIO as successor for #MP3 #622

Open
2 tasks
marwin89 opened this issue Nov 19, 2023 · 3 comments
Open
2 tasks

#AUDIO as successor for #MP3 #622

marwin89 opened this issue Nov 19, 2023 · 3 comments
Assignees
@Stefan1200-de
Labels
Song Format Official song format requirement
Milestone
Song Format v1.1....

Comments

@marwin89
Copy link
Contributor

Suggestion

  • Implement #AUDIO as successor for #MP3 in Song Parser
  • #MP3 as deprecated (will be removed in v2.0.0 ~ end of 2025)

(according to official common Song format Specification v1.1.0 - release on: 1th Dec 2023)
@marwin89 marwin89 changed the title [Song Format] #AUDIO (sucessor for #MP3) [Song Format] - #AUDIO sucessor for #MP3 Nov 19, 2023
@marwin89 marwin89 changed the title [Song Format] - #AUDIO sucessor for #MP3 [Song Format] - #AUDIO as sucessor for #MP3 Nov 19, 2023
@marwin89 marwin89 changed the title [Song Format] - #AUDIO as sucessor for #MP3 [Song Format] - #AUDIO as successor for #MP3 Nov 19, 2023
@marwin89 marwin89 changed the title [Song Format] - #AUDIO as successor for #MP3 [Label] - #AUDIO as successor for #MP3 Nov 19, 2023
@marwin89 marwin89 changed the title [Label] - #AUDIO as successor for #MP3 #AUDIO as successor for #MP3 Nov 19, 2023
@marwin89 marwin89 added the Song Format Official song format requirement label Nov 19, 2023
@Stefan1200-de Stefan1200-de self-assigned this Nov 21, 2023
@flokuep
Copy link
Member

flokuep commented Nov 21, 2023

If this is only reading the AUDIO tag, than it's easiy, as it could be just added next to the MP3-tag reading :)

Complexity: XS

@Stefan1200-de
Copy link
Member

If this is only reading the AUDIO tag, than it's easiy, as it could be just added next to the MP3-tag reading :)

Yeah, this is how I will implement it, as soon as I open my Visual Studio again -> just adding one "case" line to the song loader :)

@marwin89
Copy link
Contributor Author

@damienlaguerre: do you have some time to implement the #AUDIO? I guess It's just one line but important to keep up with the new songformat standards. 🙂 BTW: I added you to the credit section in our wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stefan1200-de Stefan1200-de

Labels
Song Format Official song format requirement
Projects
None yet
Milestone
Song Format v1.1.0 implemented
Development

No branches or pull requests
3 participants
@flokuep @Stefan1200-de @marwin89