Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple entries in various #Attributes #623

Open
marwin89 opened this issue Nov 19, 2023 · 1 comment
Open

Multiple entries in various #Attributes #623

marwin89 opened this issue Nov 19, 2023 · 1 comment
Labels
help wanted Song Format Official song format requirement

Comments

@marwin89
Copy link
Contributor

Suggestion:

  • Implement multiple entries in #GENRE, #CREATOR, #EDITION, #LANGUAGE, #TAGS
  • separated with comma ","

(according to official common Song format Specification v1.1.0 - release on: 1th Dec 2023)

@marwin89 marwin89 changed the title [Song Format] - Multiple entries in various #Attributes Multiple entries in various #Attributes Nov 19, 2023
@marwin89 marwin89 added the Song Format Official song format requirement label Nov 19, 2023
@flokuep
Copy link
Member

flokuep commented Nov 21, 2023

Editions, Genres and Langauges are already multi-value fields, but interpreted in a different way (multiple tags of the same type are allowed). The main complexity here is to not break the old behaviour and add a feature switch for the new behaviour.

  • Adjust creator in the Song-class so that it's also a multi-value field.
  • Add RawEdition, RawLanguage etc. to the Song class to keep the original values
  • After reading all tags, check the version-tag of the file. If it is > 1.1.0, split the RawValues by comma and add them to the according fileds.

Complexity: S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Song Format Official song format requirement
Projects
None yet
Development

No branches or pull requests

2 participants