Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce #INSTRUMENTAL #625

Open
marwin89 opened this issue Nov 19, 2023 · 1 comment
Open

Introduce #INSTRUMENTAL #625

marwin89 opened this issue Nov 19, 2023 · 1 comment
Labels
Song Format Official song format requirement
Milestone
Song Format v1.1....

Comments

@marwin89
Copy link
Contributor

Suggestion:

  • Introduce #INSTRUMENTAL in song parser.
  • This Attribute is for pointing to instrumental audio files with no vocals.
  • for real karaoke
  • implement select between normal or instrumental version if a txt-file contains #INSTRUMENTAL

(according to official common Song format Specification v1.1.0 - release on: 1th Dec 2023)
@flokuep flokuep added the Song Format Official song format requirement label Nov 19, 2023
@flokuep flokuep changed the title [Song Format] - Introduce #INSTRUMENTAL Introduce #INSTRUMENTAL Nov 19, 2023
@flokuep
Copy link
Member

flokuep commented Nov 21, 2023

Some notes on this are written down in #627 as these features are quite similar and should be implemented together - At least with having both in mind.

@marwin89 marwin89 mentioned this issue Jan 9, 2024
Open
@flokuep flokuep mentioned this issue Jan 28, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Song Format Official song format requirement
Projects
None yet
Milestone
Song Format v1.1.0 implemented
Development

No branches or pull requests
2 participants
@flokuep @marwin89