OC bootloader support

[liuyishengalan]

Now, I am working on OC bootloader, as I added the patch in the config.plist, the original patch didn't work. Any suggestions on it?

[leo-labs]

Awesome that you are working on an OC bootloader.
Having a look at that patch, I think I made an error. Not sure though, why it still works in clover:
I assume that the value of Name (that is com.apple.driver.AppleSMBusController right now) is the kext where the patch will be applied to. This should probably be org.rehabman.voodoo.driver.PS2Controller.

How are you applying this patch in OC?

[leo-labs]

The patch is used to remove the following line from Info.plist in VoodooPS2Controller.kext: https://github.com/leo-labs/macOS-ThinkPad-T480s/blob/master/EFI/CLOVER/backup/VoodooPS2Controller.kext/Contents/Info.plist#L65

[leo-labs]

Maybe this helps: #25 (comment)

[liuyishengalan]

Is that means to move those patches targets to clover? Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Leonard Kleinhans <notifications@github.com> Sent: Tuesday, December 17, 2019 5:52:06 AM To: leo-labs/VoodooSMBus <VoodooSMBus@noreply.github.com> Cc: YishengLiu <liuyishengalan@hotmail.com>; Author <author@noreply.github.com> Subject: Re: [leo-labs/VoodooSMBus] OC bootloader support (#20) Maybe this helps: #25 (comment)<#25 (comment)> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#20>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJ43HKUPRVYYFSYT3GB6MYLQY72ANANCNFSM4JTZOSRA>.

[gokula]

Hi,
have you managed to get it working using OC?
I can see "SMBus is busy" messages and the touchpad is not initialized. If I use my version of the driver it works using OC.

I have been going through the code trying to find the issue but found nothing.

Is that means to move those patches targets to clover? Get Outlook for Androidhttps://aka.ms/ghei36
…
________________________________ From: Leonard Kleinhans notifications@github.com Sent: Tuesday, December 17, 2019 5:52:06 AM To: leo-labs/VoodooSMBus VoodooSMBus@noreply.github.com Cc: YishengLiu liuyishengalan@hotmail.com; Author author@noreply.github.com Subject: Re: [leo-labs/VoodooSMBus] OC bootloader support (#20) Maybe this helps: #25 (comment)<#25 (comment)> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#20?email_source=notifications&email_token=AJ43HKQ5WSMQUPCK6H7NBMTQY72ANA5CNFSM4JTZOSRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHAHGMI#issuecomment-566260529>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJ43HKUPRVYYFSYT3GB6MYLQY72ANANCNFSM4JTZOSRA.

[leo-labs]

@1Revenger1 managed to fix the kext in opencore. Can you try if this build works? https://github.com/leo-labs/VoodooSMBus/actions/runs/104251907 (direct link to artifacts: https://github.com/leo-labs/VoodooSMBus/suites/680871322/artifacts/6283179)

[gokula]

Hi,
just tested and it does not work for me.

[leo-labs]

@gokula can you upload your OC config somewhere?

[1Revenger1]

A log from the kext would be nice as well. Could do something like log show --last boot | grep -i voodooinput > ~/Desktop/VoodooLog.txt, which would create a log file on your desktop

[gokula]

@leo-labs Here it goes: https://github.com/gokula/T480s-EFI (Note that you need to include the correct PlatformInfo: MLB / SystemSerialNumber / SystemUUID

It includes my version of the kext. I had already included the pci_device->setIOEnable(true);
In my code (in february) it's after the adapter->smba = pci_device->configRead16(ICH_SMB_BASE) & 0xFFFE; line.

With your current version neither the trackpad or keyboard works.

[leo-labs]

@gokula Can you please also post your log output?

[danny7g]

i took a shot at recreating the the plist patches in opencore. opencore doesn't actually allow plist patching, but just blocks the kexts from loading. the patches go in the root -> kernel -> block section. the plist is very rough outside of this section, so i wouldn't use it for anything else.

config.plist.zip

[liuyishengalan]

VoodooSMBus works pretty good in macOS 11.0 beta 1

[liuyishengalan]

Only one issue: The control panel of trackpad randomly appears in system preference setting
Function is not influenced and multi gesture is supported.

[1Revenger1]

System preference pane is locked behind battery, or atleast was in Catalina and older. I've heard numerous reports of SMCBatteryManager being broken (don't know about ACPIBatteryManager or other battery kexts). So my guess is that is that might be why it's flakey.

Good to hear that it's not completely broken in Big Sur though

[liuyishengalan]

Here it is. After several reboots...

[ioanmoldovan95]

Hey @liuyishengalan I am trying to make this work on a Thinkpad P53, and saw that you managed to make it working on a P52, could you share how did you do it? Thanks a lot

[aufuk1]

Hi,
It works on first load. But when I restart the computer, it doesn't work. The second time the computer is powered up, the trackpad does not work at all.

Opencore 0.6.3
HP EliteBook 840 G2
Intel Core i5 5300U

[aufuk1]

I guess it works because it sees VoodooPS2Trackpad.kext in VoodooPS2Controller.kext, which was previously in memory at the first load. Trackpad not working as it does not see this on second reboot.

[incontrolcloud]

Getting errors with Open Core, any ideas? Thanks!

2020-12-11 08:18:55.879657-0800  localhost kernel[0]: (IOHIDFamily) <IOHIDFamily`IOHIDLibUserClient::start(IOService*)> IOHIDLibUserClient:0x1000005a4 start failed
2020-12-11 08:18:55.879676-0800  localhost kernel[0]: (IOHIDFamily) <IOHIDFamily`IOHIDDevice::newUserClientInternal(task*, void*, OSDictionary*, IOUserClient**)> VoodooI2CMT2SimulatorDevice:0x1000002c6 failed to create user client: 0xe00002c7