Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrot: Windows rotates relative to wrong output #2355

Closed
TommyCox opened this issue May 13, 2024 · 5 comments
Closed

wrot: Windows rotates relative to wrong output #2355

TommyCox opened this issue May 13, 2024 · 5 comments
Labels

Comments

@TommyCox
Copy link

Describe the bug
Using Window Rotate on my second output rotates the window relative to the first output. Rotation on the first output still works as expected.

To Reproduce
Steps to reproduce the behavior:

  1. Enable plugin wrot.
  2. Create maximized window on secondary output.
  3. Use window rotate on said window.
  4. Move mouse to center of primary output to reset rotation.

Expected behavior
Window rotation of window on second output is relative to position on second output.

Wayfire version
0.8.1, distro package

@TommyCox TommyCox added the bug label May 13, 2024
@TommyCox
Copy link
Author

I'm guessing that the window position is getting mapped to the primary output instead of the secondary output because the way the window position is correlated to the window's output may not have been updated when wrot was refactored into a per-output plugin.

@ammen99
Copy link
Member

ammen99 commented May 13, 2024

Interesting, from your description however I cannot understand, is only the reset problematic or the rotation itself?

@TommyCox
Copy link
Author

Rotation itself is problematic. I simply didn't have good words to describe the strange behavior of trying to rotate a window around its apparent visual axis while the mouse is orbiting a different effective axis on another monitor. Thus, I chose the resetting behavior as the easiest symptom to single out and describe.

@ammen99
Copy link
Member

ammen99 commented May 13, 2024

Here is a patch which might fix the issue, please test: https://0x0.st/XKtF.diff

@TommyCox
Copy link
Author

Yes, that appears to have fixed the problem for me. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants