Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.13.0 of gtest requires C++14 #830

Open
musicinmybrain opened this issue Jan 27, 2023 · 0 comments
Open

Version 1.13.0 of gtest requires C++14 #830

musicinmybrain opened this issue Jan 27, 2023 · 0 comments

Comments

@musicinmybrain
Copy link

The latest version of gtest (1.13.0) requires C++14, but easyloggingpp compiles and runs its tests as C++11.

In file included from /usr/include/gtest/gtest-message.h:57,
                 from /usr/include/gtest/gtest-assertion-result.h:46,
                 from /usr/include/gtest/gtest.h:64,
                 from /builddir/build/BUILD/easyloggingpp-8489989bb26c6371df103f6cbced3fbee1bc3c2f/test/test.h:11,
                 from /builddir/build/BUILD/easyloggingpp-8489989bb26c6371df103f6cbced3fbee1bc3c2f/test/main.cc:3:
/usr/include/gtest/internal/gtest-port.h:270:2: error: #error C++ versions less than C++14 are not supported.
  270 | #error C++ versions less than C++14 are not supported.
      |  ^~~~~

This will be increasingly problematic for some users. For example, Linux distribution packages working with system copies of gtest will have to patch the tests to use C++14. (I maintain the easyloggingpp package in Fedora Linux).

Presumably you would stop claiming C++11 support if you stop testing it. Is there a plan to do this, moving forward to C++14 as the new minimum? Any other suggestions?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant