Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the "broken" image file used when a listing doesn't have an image with something else #1187

Closed
EchterAgo opened this issue Aug 7, 2018 · 9 comments · Fixed by #1314

Comments

@EchterAgo
Copy link

When a listing does not have an image file an icon that seems to imply a broken image is used. When I see this it always makes me wonder if there is a problem with my internet connection or the website on first sight. It takes me a few milliseconds to remember that it means "no image" instead of "broken image", even though I work on the site regularly. Other users might not even realize that this does mean no image. We should consider replacing that with either a better symbol or even omitting the image circle completely for these listings.

@EchterAgo
Copy link
Author

Another issue is that the icon used is an exact copy of the icon that Internet Explorer used to indicate a broken image, so there might be licensing problems with this.

@EchterAgo
Copy link
Author

I would prefer omitting the circle and not displaying anything there.

@kenman345
Copy link
Member

it throws off the spacing. I guess we can do it though, I believe we can just use an empty gray image like we do for the lazyload for missing ones if that would be better without much code change?

@EchterAgo
Copy link
Author

Adding style="visibility: hidden;" to the img tag where we have no image hides it without messing with the layout. I think an empty image would be better than what we have now, but it might also be seen as problems with the connection or the site. I'll check if I can come up with a symbol.

@EchterAgo
Copy link
Author

@EchterAgo
Copy link
Author

noimage
noimage2

One of these might also work.

@EchterAgo
Copy link
Author

@chaintip 100 days

@chaintip
Copy link

0.01029365 BCH| ~ 5.02 USD has been tipped to this issue by @EchterAgo.
To claim this bounty, get a pull request merged with @chaintip fixes #1187 in the creation comment.

@thecoklat
Copy link

When a listing does not have an image file an icon that seems to imply a broken image is used. When I see this it always makes me wonder if there is a problem with my internet connection or the website on first sight. It takes me a few milliseconds to remember that it means "no image" instead of "broken image", even though I work on the site regularly. Other users might not even realize that this does mean no image. We should consider replacing that with either a better symbol or even omitting the image circle completely for thes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants