Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fulfill requirements to meet Web Accessibility standards #380

Open
t0p0lin0 opened this issue Jan 5, 2018 · 10 comments
Open

Fulfill requirements to meet Web Accessibility standards #380

t0p0lin0 opened this issue Jan 5, 2018 · 10 comments

Comments

@t0p0lin0
Copy link

t0p0lin0 commented Jan 5, 2018

Targetting WCAG level AA success criteria.

@t0p0lin0 t0p0lin0 changed the title Fulfill requirements to meet Accessibility standards Fulfill requirements to meet Web Accessibility standards Jan 5, 2018
@kenman345
Copy link
Member

Is there a guide? I think I can handle doing some of this since its Jekyll and we generate most of our on page content from the same set of code, but it would be nice if we can do this, preferably if you can take this on or think about as we build out the new pages.

@t0p0lin0
Copy link
Author

You can actually issue an Accessibility audit through Chrome's devtools:

image

However it just seems to hang for me. There is a guideline linked to above in my original comment (WCAG level AA), but that's not too straight forward. Recommending we leave this open, in hopes that an expert will be willing to save the day...someday.

@kenman345
Copy link
Member

is this something that can help?
https://github.com/marketplace/accesslint

@kenman345
Copy link
Member

i tested it out and this is how it looks: https://github.com/kenman345/acceptbitcoincash/pull/22/files#diff-b893a2e076cee8dcb56202691f2881d2R9

I am thinking about wiping on my repo all the files and then reverting that and then committing it so I can get it to do the heavy lifting instead of using this simply as a maintenance tool for new code.

@kenman345
Copy link
Member

so this tool is fine but it doesnt work on the compiled pages so it may miss things

@kenman345
Copy link
Member

erm, HTML proofer has these checks: gjtorikian/html-proofer#382

I I ran it against some of our stuff and it found a few issues.

https://travis-ci.org/kenman345/acceptbitcoincash/jobs/337800948#L1095

I think we can quite easily accommodate these changes and I think it would be a worthwhile effort during a refactor for accessibility.

@kenman345
Copy link
Member

Sp SRI tags can be generated on the fly by Jekyll. Someone even made a plugin we can use and wrote up why and how here: https://vcsjones.com/2016/11/02/sri-with-jekyll/

This would be good to implement during our Web Accessibility refactoring efforts. The Travis-CI tests indicate we only have about 10 links/script tags that would need this functionality added to.

As far as web accessibility, I have not found any particular tool that works extremely well. I think we need to refactor our partials first though so fixing these types of issues fixes it everywhere instead of making a fix and potentially losing that fix if we forgot we did it during refactoring the re-used sections of our site.

@kenman345
Copy link
Member

would be nice if someone could help with this, i'm not too capable of getting to it, as is noticable by how long this has been open

@kenman345
Copy link
Member

@t0p0lin0 Can we get on this? I feel that accessibility is more than a nice to have in this day and age, but a requirement. I would love to learn this stuff but I have little experience and your expertise can be very helpful.

@kenman345 kenman345 pinned this issue Oct 21, 2019
@kenman345
Copy link
Member

this tool seems to really help, so I'm just suggesting it if anyone is gonna pick up the torch on this one. https://chrome.google.com/webstore/detail/wave-evaluation-tool/jbbplnpkjmmeebjpijfedlgcdilocofh?hl=en-US

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants