Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

Problem with ISO location in other partition #211

Open
jabarea opened this issue Jun 13, 2018 · 1 comment
Open

Problem with ISO location in other partition #211

jabarea opened this issue Jun 13, 2018 · 1 comment

Comments

@jabarea
Copy link

jabarea commented Jun 13, 2018

If we change the ISO location to other USB partition:
set isopath='(hd0,msdos2)/isos'

There is a problem showing the name of the system at boot time in GRUB's menu.
I think is a problem with this line in the scripts:
regexp --set=isoname "$isopath/(.*)" "$isofile"
I suppose that is because of the round brackets "()" of the path.
I don't know which is the best solution for this issue, I have fixed it replacing the line with this one:
regexp --set=isoname "[$isopath]/(.*)" "$isofile"
But I don't know if this could be a problem in other situations.

Thank you very much.

@aguslr
Copy link
Owner

aguslr commented Sep 22, 2018

Hi @jabarea!

That's an interesting issue. It does seem that the parenthesis mess up the regexp. You could try something like regexp --set=isoname ".*/([A-Za-z0-9_\-\.]*)" "$isofile".

This regular expression should cover most of the characters used in ISO names although it'd take a bit of work to replace it in all configuration files. 🤔

Edit: Actually, it seems that regexp --set=isoname ".*/(.*)" "$isofile" should suffice.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants