Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't accept multiple connections from the same peer #50

Open
alexdovzhanyn opened this issue Aug 28, 2018 · 2 comments
Open

Don't accept multiple connections from the same peer #50

alexdovzhanyn opened this issue Aug 28, 2018 · 2 comments
Labels
Enhancement New feature or request Good First Issue Good for newcomers Help Wanted Extra attention is needed

Comments

@alexdovzhanyn
Copy link
Owner

2 peers shouldn't be able to connect to more than one of each others handlers, this clogs up the network distribution and allows for a potential peer isolation attack.

Peers should check other handlers before accepting a connection, and reject a connection if there is another handler already talking to the peer which started a second connection.

@alexdovzhanyn alexdovzhanyn added Enhancement New feature or request Help Wanted Extra attention is needed labels Aug 28, 2018
@alexdovzhanyn alexdovzhanyn added the Good First Issue Good for newcomers label Nov 6, 2018
@fantypants
Copy link
Contributor

Updates?

@alexdovzhanyn
Copy link
Owner Author

This was semi-fixed for a while with a little hack i put together but ultimately i ended up removing it because of race conditions that caused too many crashes. Still something that needs to get fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Good First Issue Good for newcomers Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants