Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connection only with confirmation #140

Open
freeconst opened this issue Jun 27, 2022 · 3 comments
Open

Allow connection only with confirmation #140

freeconst opened this issue Jun 27, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@freeconst
Copy link

In addition to authorized connections, it would be nice to add connection requests for privacy. Some x0vnc QueryConnect analog.

@any1
Copy link
Owner

any1 commented Jun 27, 2022

There could be an option to call a user defined command upon connection, which would determine if the connection is accepted or not.

@lack
Copy link
Collaborator

lack commented Dec 18, 2022

Now that we have an IPC mechanism in wayvncctl, maybe this would be easier to do.

I'd suggest a new IPC command like event-receive that would register a client to be an auth-handler.

Then the client could expect to receive an auth-attempt IPC call, and would be expected to respond with a allow/disallow response.

Care must be taken to deal with the server's behavior with multiple IPC clients, and what to do in the event of nonresponse arriving.

@any1
Copy link
Owner

any1 commented Jan 15, 2023

This is probably a good enough solution:

  • The authentication method is configured in the config file or in a command line argument to wayvnc
  • If the method is set to "query", we do the following:
  • Generate a "client-auth-request" event when a client connects
  • The event contains the user's submitted credentials.
  • When an instance of wayvncctl receives this event, it calls wayvncctl client-auth-accept or wayvncctl client-auth-reject [reason]
  • If the server does not receive an accept or reject command from wayvncctl within the timeout period, the client is rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants