Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs about request locking #2467

Open
drobnikj opened this issue May 15, 2024 · 3 comments
Open

Improve docs about request locking #2467

drobnikj opened this issue May 15, 2024 · 3 comments
Assignees
Labels
feature Issues that represent new features or improvements to existing features. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@drobnikj
Copy link
Member

Which package is the feature request for? If unsure which one to select, leave blank

@crawlee/core

Feature

After releasing the new request queue storage system, we should improve the docs about locking.
Currently, there is outdated information in experiments, see https://crawlee.dev/docs/next/experiments/experiments-request-locking .

We can add info and explanation about locking somewhere into crawlee docs.

Motivation

Inform users of crawlee how the locking works under the hood.

Ideal solution or implementation, and any additional constraints

The ideal state would be to have documented how locking works under the hood in crawlee.

Alternative solutions or implementations

No response

Other context

No response

@drobnikj drobnikj added the feature Issues that represent new features or improvements to existing features. label May 15, 2024
@B4nan
Copy link
Member

B4nan commented May 15, 2024

Is this for your team or do you want us to handle it?

@B4nan
Copy link
Member

B4nan commented May 22, 2024

@drobnikj let me ask again, is this for you or for us? :]

@drobnikj
Copy link
Member Author

@B4nan I think It would be good task for @vladfrangu as he did the implementation in crawlee. I think we need to add:

  • info on how locking works in crawlee
  • example of how you can use locking to scrape one request queue from multiple crawlee instances
  • remove the section about experiments request queue locking

@B4nan B4nan added the t-tooling Issues with this label are in the ownership of the tooling team. label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues that represent new features or improvements to existing features. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

3 participants