Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The is_public setting for services appears to be ignored #699

Open
jakubgs opened this issue Oct 21, 2020 · 5 comments · May be fixed by #700
Open

The is_public setting for services appears to be ignored #699

jakubgs opened this issue Oct 21, 2020 · 5 comments · May be fixed by #700

Comments

@jakubgs
Copy link

jakubgs commented Oct 21, 2020 •
edited

I tried creating a service using the API but it seems to be ignoring the is_public setting.

I've also tried making it public by hand and then fetching services and I don't see it in the JSON. Is it just not supported?

I'm running cabotapp/cabot:0.11.16 Docker image.
@dbuxton
Copy link
Contributor

dbuxton commented Oct 21, 2020

Doesn't look like it - feel free to submit a PR

https://github.com/arachnys/cabot/blob/master/cabot/rest_urls.py#L50

@jakubgs
Copy link
Author

jakubgs commented Oct 21, 2020

So I guess the same goes for email_alert, which also appears to be ignored.

@jakubgs
Copy link
Author

jakubgs commented Oct 21, 2020

Based on the PRs currently open it doesn't seem like it has a high chance of getting merged.

Example: #672

@jakubgs
Copy link
Author

jakubgs commented Oct 21, 2020

I have attempted to make this change in status-im@6841f8f7 by adding is_public and email_alert but is_public works, but email_alert appears to have no effect. Not sure why that is.

@jakubgs
Copy link
Author

jakubgs commented Oct 21, 2020

I opened the PR: #700

But I don't know why email_alert has no effect.

@jakubgs jakubgs linked a pull request Oct 21, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make email_alert field available via services API status-im/cabot
2 participants
@dbuxton @jakubgs