Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erase granularity not set correctly on non-uniform flash #55

Open
davidk88 opened this issue Aug 3, 2021 · 1 comment · May be fixed by #74
Open

Erase granularity not set correctly on non-uniform flash #55

davidk88 opened this issue Aug 3, 2021 · 1 comment · May be fixed by #74

Comments

@davidk88
Copy link

davidk88 commented Aug 3, 2021

Hello,

I'm using S25FL127S which does not support uniform 4k erase.

Library correctly reports via SFDP that flash chip does not supports uniform 4k erase, but it sets erase_gran and erase_gran_cmd to 4k erase anyway.

I modified library in such way that if sfdp.4k_erase is 0 then erase_gran and erase_gran_cmd is set to first eraser size which is larger than 4k, but I'm not sure if this is the correct way. I also dif not find any flags in SFDP that would tell which erase size is uniform for whole device.

Best regards

@armink
Copy link
Owner

armink commented Aug 3, 2021

Yes, when an unsupported erase size is found, and the erase size can be enlarged. You can submit your changes by PR.

@davidk88 davidk88 linked a pull request Aug 31, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants