Search in directory: search in file with Windows-1251 (cyrillic) encoding

[ghost]

Description

When you try to search for a latin substring in the list of files containing latin and cyrillic characters and saved in windows-1251 encoding, the search engine does not return any result.

Steps to Reproduce

1. Create file with containing text:
   some text with кирилическими символами
2. Save file with windows-1251 encoding in some directory
3. Try to search in this directory substring some text with no opening file on new page.

Expected behavior: returns a list of files containing the searched substring

Actual behavior: the search engine does not return any result

Reproduces how often: always

Versions

OS: Windows 10
Atom: 1.14.2

[rsese]

I think I was able to reproduce but to clarify:

2. Save file with windows-1251 encoding in some directory

Can you confirm how you perform this step?

[ousennin]

Yes, the bug is present. It is caused by bug in node module 'scandal'. It simply opens files for search in wrong codepage or even worse - as a binary...

[ghost]

to @rsese

Can you confirm how you perform this step?

Sure, you can do this in Atom, just open new file, select encoding windows-1251 (on the bottom of Atom panel), insert into file content some text with кирилическими символами, save them in some folder. Now you can try Search in direcory phrase 'some text'.

[Ben3eeE]

@rsese I found three issues related to find-and-replace not working with various encodings. atom/find-and-replace#741 and atom/find-and-replace#751 that can be duplicates for this and atom/find-and-replace#819 that is possibly related.

[rsese]

Thanks for the pointers @Ben3eeE ⚡ Not sure why I didn't search the find-and-replace package....those do seem like basically the same issue.

We'll go ahead and close this as a duplicate @st1gus but you can subscribe to any of those issues above if you want to follow along.

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!