You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
It's difficult enough to write a good PR, and for the specs to fail in an unrelated way is really disheartening.
I would really appreciate scheduling tests of all packages so that things like this can be caught. Travis CI allows this. Successes can be ignored, failures quickly checked for network issues (and restarted), and true failures / flaky tests will be found a lot quicker than whenever someone makes the next PR.
Yeah, I have noted that the CI hasn't been run in a while and devDependencies for several of the packages are out of date. A lot of them last tested against Electron 4, 1, 0.1, etc. (I just recently posted a PR to fix CI for atom/etch.)
Prerequisites
NA
Description
Two for two packages I've worked on recently have failing specs on the master branch (errored even when all changes in the PR were reverted).
Object.keys
, so a pre-existing bug was uncoveredIt's difficult enough to write a good PR, and for the specs to fail in an unrelated way is really disheartening.
I would really appreciate scheduling tests of all packages so that things like this can be caught. Travis CI allows this. Successes can be ignored, failures quickly checked for network issues (and restarted), and true failures / flaky tests will be found a lot quicker than whenever someone makes the next PR.
/cc @lkashef @darangi
The text was updated successfully, but these errors were encountered: