Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Project-wide find and replace with regex does not replace #4154

Closed
shawnacscott opened this issue Nov 11, 2014 · 6 comments
Closed

Project-wide find and replace with regex does not replace #4154

shawnacscott opened this issue Nov 11, 2014 · 6 comments
Assignees

Comments

@shawnacscott
Copy link

The find and replace with the project-wide tool (Cmd-Shift-F) is refusing to make replacements. I can replace with a standard find and replace, but not with the regex option enabled.

Atom 0.145.0, OS X 10.10
No errors were logged in the Atom console, or in Console.app.

atom_find_and_replace_issue

@50Wliu
Copy link
Contributor

50Wliu commented Nov 12, 2014

I'm noticing that it's saying that it's replacing 18 out of 15 files...

@benogle benogle self-assigned this Nov 12, 2014
@benogle benogle added the bug label Nov 12, 2014
@marnen
Copy link

marnen commented Oct 5, 2015

Still having this issue with complex regexes in 1.0.19 (Mac OS X 10.10). The specific regex I've been using is as follows.
Find: \((->[^\u0000]*?)\n\s*\)\.observes[( ](.*?)[) ]?$
Replace: Ember.observer $2, $1

@bbasic
Copy link

bbasic commented Nov 5, 2015

Same here.
I tried to use following regex table-responsive.*(.|[\r\n])\s+<table simply to find files having matching text.
With Find in Project it doesn't work. However, when I use Find in Buffer in a file that has the matching text, it finds the matching text.

Atom 1.1.0
Mac OS X 10.10

@benogle
Copy link
Contributor

benogle commented Nov 5, 2015

The issue is the newline in both @bbasic and @marnen's comments. See atom/scandal#5 for more info

@infinitec
Copy link

Project find and replace is not working for me with the following expressions.
Find: ("\+[a-z,A-Z]*)" \);$
Replace: $1+"" );

The interface highlights the potential replacement just fine. It prompts for confirmation on replace. However, once I confirm, it seems to attempt replacement then reloads the found results and indicates that nothing was replaced.

@stale stale bot added the stale label Aug 29, 2017
@stale stale bot closed this as completed Sep 12, 2017
@lock
Copy link

lock bot commented Mar 30, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked and limited conversation to collaborators Mar 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants