Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

PHP Heredoc breaks folding #372

Closed
1 task done
boogiefromzk opened this issue Nov 7, 2019 · 1 comment
Closed
1 task done

PHP Heredoc breaks folding #372

boogiefromzk opened this issue Nov 7, 2019 · 1 comment

Comments

@boogiefromzk
Copy link

Description

Steps to Reproduce

Example: creating a PHP file with following content:
`<?php

function test() {
$var = <<<HTML
some heredoc text
HTML;
}`

Сlicking folding icon on the line with the function and see this:

`<?php

function test() {
HTML;
}`

Same with anything which is not shifted to the right on any level of brackets.

Expected behavior:

Expect correct folding

Actual behavior:

Folding is broken

Reproduces how often:

100%

Versions

Atom : 1.41.0
Electron: 4.2.7
Chrome : 69.0.3497.128
Node : 10.11.0
apm 2.4.3
npm 6.2.0
node 10.2.1 x64
atom 1.41.0
python 2.7.14
git 2.16.4

Atom 1.41.0 x64 RPM package for Linux

Additional Information

This issue is still actual with tree-sitter enabled.
atom/atom#3442

@rsese rsese transferred this issue from atom/atom Nov 16, 2019
@rsese
Copy link

rsese commented Nov 16, 2019

This issue is still actual with tree-sitter enabled.
atom/atom#3442

language-php isn't using Tree-sitter yet /cc #303.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants