Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

isPathIgnored doesn't work with some ignoredNames #20

Open
alvaromartin opened this issue Nov 18, 2014 · 5 comments
Open

isPathIgnored doesn't work with some ignoredNames #20

alvaromartin opened this issue Nov 18, 2014 · 5 comments

Comments

@alvaromartin
Copy link

I just posted in discuss.atom.io explaining in depth an ignoredNames inconsistency issue between tree-view, fuzzy-finder and find-and-replace.

https://discuss.atom.io/t/ignorednames-issue/13299

I summary, scandal file search indexing is inconsistent with fuzzy-finder because instead of matching full file paths it's using relative file paths.

https://github.com/atom/scandal/blob/master/src/path-filter.coffee#L79

@benogle
Copy link
Contributor

benogle commented Nov 18, 2014

Based on your explanation, I feel like fuzzy-finder should use relative paths. Then your example becomes:

'global':
  'core':
    'ignoredNames': [
       'static/**'
    ]

Also, I rather like being able to type src into the paths box in find and replace to only search the src dir of my project.

@lee-dohm
Copy link
Contributor

Related: atom/tree-view#256

@alvaromartin
Copy link
Author

I just tried

'global':
  'core':
    'ignoredNames': [
       'static/**'
    ]

and now both static folders are ignored when I search.

@benogle
Copy link
Contributor

benogle commented Nov 18, 2014

and now both static folders are ignored when I search.

Is this good or bad?

@alvaromartin
Copy link
Author

projects
  project
    app
      static // dont want to ignore
        test.js
    static // want to ignore
      test.js

bad

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants