Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Audit startup time impact #136

Closed
nathansobo opened this issue Oct 26, 2017 · 4 comments
Closed

Audit startup time impact #136

nathansobo opened this issue Oct 26, 2017 · 4 comments

Comments

@nathansobo
Copy link
Contributor

Saw this today:

screen shot 2017-10-26 at 9 51 02 am

Since we won't be bundling this package initially, it may be worth looking into how to minimize its impact on startup time.

@jasonrudolph
Copy link
Contributor

Good point. I suspect the network requests are the major contributors to the startup time:

settings_ ___github_real-time

@jasonrudolph
Copy link
Contributor

I suspect the network requests are the major contributors to the startup time

If we postpone the protocol version check until the user interacts with the popover (as suggested in #137), these network requests wouldn't impact the startup time.

@jasonrudolph
Copy link
Contributor

Closing in favor of #201.

@50Wliu
Copy link
Contributor

50Wliu commented Nov 16, 2017

Sorry! Didn't think of searching issues because of how new this package was :/.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants